mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-03 13:16:04 +00:00
Code Issues 1 Projects Releases Wiki Activity

gloverlaycompositor: Don't leak caps feature

Browse source 
Only copy it if we really are going to modify and use it

CID #1439873

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/652>
This commit is contained in:
Edward Hervey 2020-05-05 17:17:57 +02:00 committed by Edward Hervey
parent 637bbac622
commit add3023f09
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ext/gl/gstgloverlaycompositorelement.c
View file

@ -156,16 +156,13 @@ _oce_transform_internal_caps (GstGLFilter * filter,
for (i = 0; i < n; i++) {
GstCapsFeatures *feat = gst_caps_get_features (removed, i);
if (feat) {
if (feat && gst_caps_features_contains (feat,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION)) {
feat = gst_caps_features_copy (feat);
if (gst_caps_features_contains (feat,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION)) {
/* prefer the passthrough case */
gst_caps_features_remove (feat,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION);
gst_caps_set_features (removed, i, feat);
}
/* prefer the passthrough case */
gst_caps_features_remove (feat,
GST_CAPS_FEATURE_META_GST_VIDEO_OVERLAY_COMPOSITION);
gst_caps_set_features (removed, i, feat);
}
}