mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

hls: fix handling of strol() overflows

Browse source
This commit is contained in:
Alessandro Decina 2011-05-15 10:00:44 +02:00
parent 9b23e213cb
commit adc0817b2a
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
gst/hls/m3u8.c
View file

@ -104,21 +104,29 @@ static gboolean
int_from_string (gchar * ptr, gchar ** endptr, gint * val) int_from_string (gchar * ptr, gchar ** endptr, gint * val)
{ {
gchar *end; gchar *end;
glong ret;
g_return_val_if_fail (ptr != NULL, FALSE); g_return_val_if_fail (ptr != NULL, FALSE);
g_return_val_if_fail (val != NULL, FALSE); g_return_val_if_fail (val != NULL, FALSE);
errno = 0; errno = 0;
*val = strtol (ptr, &end, 10); ret = strtol (ptr, &end, 10);
if ((errno == ERANGE && (*val == LONG_MAX || *val == LONG_MIN)) if ((errno == ERANGE && (ret == LONG_MAX || ret == LONG_MIN))
|| (errno != 0 && *val == 0)) { || (errno != 0 && ret == 0)) {
GST_WARNING ("%s", g_strerror (errno)); GST_WARNING ("%s", g_strerror (errno));
return FALSE; return FALSE;
} }
if (ret > G_MAXINT) {
GST_WARNING ("%s", g_strerror (ERANGE));
return FALSE;
}
if (endptr) if (endptr)
*endptr = end; *endptr = end;
*val = (gint) ret;
return end != ptr; return end != ptr;
} }