mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-05 22:25:55 +00:00
Code Issues 1 Projects Releases Wiki Activity

glupload: create the GstGLUpload object in ::transform_caps

Browse source 
Previously it was created in the init function and destroyed in ::stop, which
lead to segfaults when reusing the element.

Now the upload object is created in ::transform_caps if it is NULL, which is the
earliest we need it. The other vfuncs already bail out if the upload object is
NULL, which means that negotiation wasn't done.
This commit is contained in:
Alessandro Decina 2016-09-05 14:44:24 +10:00 committed by Tim-Philipp Müller
parent ae89055e67
commit acd33a240f
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ext/gl/gstgluploadelement.c
View file

@ -97,8 +97,6 @@ static void
gst_gl_upload_element_init (GstGLUploadElement * upload)
{
gst_base_transform_set_prefer_passthrough (GST_BASE_TRANSFORM (upload), TRUE);
upload->upload = gst_gl_upload_new (NULL);
}
static gboolean
@ -138,6 +136,9 @@ _gst_gl_upload_element_transform_caps (GstBaseTransform * bt,
GstGLUploadElement *upload = GST_GL_UPLOAD_ELEMENT (bt);
GstGLContext *context = GST_GL_BASE_FILTER (bt)->context;
if (upload->upload == NULL)
upload->upload = gst_gl_upload_new (NULL);
return gst_gl_upload_transform_caps (upload->upload, context, direction, caps,
filter);
}