mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-22 17:51:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: Protect init function with a recursive mutex

Browse source 
In tests in the rust bindings we end up with 2 thread initializing
concurrently, and it should not be a problem, -validate should be MT
safe.

Using a recursive mutex as we might recursively init for some reason
and we are not on the hot path here in any case.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4089>
This commit is contained in:
Thibault Saunier 2023-03-01 00:56:51 -03:00 committed by GStreamer Marge Bot
parent 12c4893131
commit accbcabeea
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
subprojects/gst-devtools/validate/gst/validate/validate.c
View file

@ -55,6 +55,8 @@ GST_DEBUG_CATEGORY (gstvalidate_debug);
static GMutex _gst_validate_registry_mutex; static GMutex _gst_validate_registry_mutex;
static GstRegistry *_gst_validate_registry_default = NULL; static GstRegistry *_gst_validate_registry_default = NULL;
static GRecMutex init_lock = { 0, };
G_LOCK_DEFINE_STATIC (all_configs_lock); G_LOCK_DEFINE_STATIC (all_configs_lock);
static GList *all_configs = NULL; static GList *all_configs = NULL;
static gboolean got_configs = FALSE; static gboolean got_configs = FALSE;
@ -469,7 +471,9 @@ gst_validate_init_debug (void)
void void
gst_validate_init (void) gst_validate_init (void)
{ {
g_rec_mutex_lock (&init_lock);
if (validate_initialized) { if (validate_initialized) {
g_rec_mutex_unlock (&init_lock);
return; return;
} }
gst_validate_init_debug (); gst_validate_init_debug ();
@ -493,6 +497,7 @@ gst_validate_init (void)
gst_validate_flow_init (); gst_validate_flow_init ();
gst_validate_init_plugins (); gst_validate_init_plugins ();
gst_validate_init_runner (); gst_validate_init_runner ();
g_rec_mutex_unlock (&init_lock);
} }
void void