mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

base: adapter: Explicitly mark size parameter as input

Browse source 
The generated gir file marks the size parameter as "out" by default.
This is wrong in the context of a caller allocated buffer with a given size.
Explicitly marking the size parameter as (in) fixes the issue.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4399>
This commit is contained in:
badcel 2023-04-11 21:23:00 +02:00 committed by GStreamer Marge Bot
parent 901383771d
commit acb913a878
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gstreamer/libs/gst/base/gstadapter.c
View file

@ -581,7 +581,7 @@ gst_adapter_unmap (GstAdapter * adapter)
* @dest: (out caller-allocates) (array length=size) (element-type guint8): * @dest: (out caller-allocates) (array length=size) (element-type guint8):
* the memory to copy into * the memory to copy into
* @offset: the bytes offset in the adapter to start from * @offset: the bytes offset in the adapter to start from
* @size: the number of bytes to copy * @size: (in): the number of bytes to copy
* *
* Copies @size bytes of data starting at @offset out of the buffers * Copies @size bytes of data starting at @offset out of the buffers
* contained in #GstAdapter into an array @dest provided by the caller. * contained in #GstAdapter into an array @dest provided by the caller.