mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-23 09:04:15 +00:00
Code Issues 1 Projects Releases Wiki Activity

pool: fix deallocation of video pools.

Browse source 
The queue of free objects to used was deallocated with g_queue_free_full().
However, this convenience function shall only be used if the original queue
was allocated with g_queue_new(). This caused memory corruption, eventually
leading to a crash.

The correct solution is to pair the g_queue_init() with the corresponding
g_queue_clear(), while iterating over all free objects to deallocate them.
This commit is contained in:
Gwenole Beauchesne 2013-07-12 15:01:01 +02:00
parent 9b3ad4daad
commit ac75755105
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst-libs/gst/vaapi/gstvaapivideopool.c
View file

@ -70,7 +70,8 @@ void
gst_vaapi_video_pool_finalize(GstVaapiVideoPool *pool) gst_vaapi_video_pool_finalize(GstVaapiVideoPool *pool)
{ {
g_list_free_full(pool->used_objects, gst_vaapi_object_unref); g_list_free_full(pool->used_objects, gst_vaapi_object_unref);
g_queue_free_full(&pool->free_objects, gst_vaapi_object_unref); g_queue_foreach(&pool->free_objects, (GFunc)gst_vaapi_object_unref, NULL);
g_queue_clear(&pool->free_objects);
gst_vaapi_display_replace(&pool->display, NULL); gst_vaapi_display_replace(&pool->display, NULL);
} }