mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-22 01:31:03 +00:00
Code Issues 1 Projects Releases Wiki Activity

flacenc: Correctly handle up to 255 cue entries

Browse source 
The counter was using a signed 8 bit integer, which was overflowing
after 127 entries. That was then passed as an unsigned 32 bit integer to
libflac, which caused it to be converted to a huge unsigned number.
That then caused an invalid memory access inside libflac.

As a bonus, signed integer overflow is undefined behaviour.

Instead, use an unsigned 8 bit integer. Once this overflows the existing
code already catches it and stops adding the cue. While FLAC__metadata_object_cuesheet_insert_track()
takes an unsigned 32 bit integer for the track number, FLAC__StreamMetadata_CueSheet_Track is
limiting it to an unsigned 8 bit integer.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2921

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5420>
This commit is contained in:
Sebastian Dröge 2023-09-28 18:03:31 +03:00 committed by GStreamer Marge Bot
parent 9ec430c713
commit abdd1967ad
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subprojects/gst-plugins-good/ext/flac/gstflacenc.c
View file

@ -484,7 +484,7 @@ static gboolean
add_cuesheet (const GstToc * toc, guint sample_rate, add_cuesheet (const GstToc * toc, guint sample_rate,
FLAC__StreamMetadata * cuesheet) FLAC__StreamMetadata * cuesheet)
{ {
gint8 track_num = 0; guint8 track_num = 0;
gint64 start, stop; gint64 start, stop;
gchar *isrc = NULL; gchar *isrc = NULL;
const gchar *is_legal; const gchar *is_legal;