mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-22 17:51:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

audioparsers: add back segment clipping to parsers that have lost it

Browse source 
The pre_push_frame default clipping behaviour was introduced in 2010
with commit 30be03004e and modified with commit 4163969a24 in 2011,
when most parsers didn't implement a pre_push_frame yet. Not having it
meant that clipping was done by default. Those that did implement a
pre_push_frame (flacparse and mpegaudioparse) at the time, had the flag
adjusted as part of the 2011 refactor work.

All other parsers got a pre_push_frame vfunc implementation only in
2013, but seem to have forgot to keep the clipping behaviour, as
was done automatically when a pre_push_frame implementation doesn't
exist for the parser. aacparse lost it with commit 91d4abcea in
July 2013; the others in Dec 2013 as part of AUDIO_CODEC tag posting
in commits 6f89b430e, d2ab5199b, 29f2cae12, 753d3c23a and 292780574.
This commit is contained in:
Mart Raudsepp 2019-06-24 14:28:39 +03:00
parent 92e4ecef4c
commit ab6e49e9cc
6 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/audioparsers/gstaacparse.c
View file

@ -1480,6 +1480,8 @@ gst_aac_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
gst_buffer_get_size (frame->out_buffer) - header_size); gst_buffer_get_size (frame->out_buffer) - header_size);
} }
frame->flags |= GST_BASE_PARSE_FRAME_FLAG_CLIP;
return GST_FLOW_OK; return GST_FLOW_OK;
} }

2
gst/audioparsers/gstac3parse.c
View file

@ -808,6 +808,8 @@ gst_ac3_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
ac3parse->sent_codec_tag = TRUE; ac3parse->sent_codec_tag = TRUE;
} }
frame->flags |= GST_BASE_PARSE_FRAME_FLAG_CLIP;
return GST_FLOW_OK; return GST_FLOW_OK;
} }

2
gst/audioparsers/gstamrparse.c
View file

@ -448,5 +448,7 @@ gst_amr_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
amrparse->sent_codec_tag = TRUE; amrparse->sent_codec_tag = TRUE;
} }
frame->flags |= GST_BASE_PARSE_FRAME_FLAG_CLIP;
return GST_FLOW_OK; return GST_FLOW_OK;
} }

2
gst/audioparsers/gstdcaparse.c
View file

@ -613,5 +613,7 @@ gst_dca_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
dcaparse->sent_codec_tag = TRUE; dcaparse->sent_codec_tag = TRUE;
} }
frame->flags |= GST_BASE_PARSE_FRAME_FLAG_CLIP;
return GST_FLOW_OK; return GST_FLOW_OK;
} }

2
gst/audioparsers/gstsbcparse.c
View file

@ -530,5 +530,7 @@ gst_sbc_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame)
sbcparse->sent_codec_tag = TRUE; sbcparse->sent_codec_tag = TRUE;
} }
frame->flags |= GST_BASE_PARSE_FRAME_FLAG_CLIP;
return GST_FLOW_OK; return GST_FLOW_OK;
} }

2
gst/audioparsers/gstwavpackparse.c
View file

@ -704,5 +704,7 @@ gst_wavpack_parse_pre_push_frame (GstBaseParse * parse,
wavpackparse->sent_codec_tag = TRUE; wavpackparse->sent_codec_tag = TRUE;
} }
frame->flags |= GST_BASE_PARSE_FRAME_FLAG_CLIP;
return GST_FLOW_OK; return GST_FLOW_OK;
} }