mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-22 17:51:16 +00:00
Code Issues 1 Projects Releases Wiki Activity

va: deinterlace: Do not use the backward reference

Browse source 
num_backward_references > 0 means we need to cache several frames
after the current frame. But the basetransform class does not
provide any _drain() kind function, so we do not have the chance
to push out our cached frames when EOS or set caps event comes.
Rather than losing the last several frames, we should just give up
the backward reference here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7348>
This commit is contained in:
He Junyan 2024-08-13 23:55:47 +08:00 committed by GStreamer Marge Bot
parent 11a0b40b6e
commit a924e6c8bc
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
subprojects/gst-plugins-bad/sys/va/gstvadeinterlace.c
View file

@ -263,6 +263,19 @@ _build_filter (GstVaDeinterlace * self)
} }
GST_INFO_OBJECT (self, "References for method: %u forward / %u backward", GST_INFO_OBJECT (self, "References for method: %u forward / %u backward",
self->num_forward_references, self->num_backward_references); self->num_forward_references, self->num_backward_references);
/* num_backward_references > 0 means we need to cache several frames
after the current frame. But the basetransform class does not
provide any _drain() kind function, so we do not have the chance
to push out our cached frames when EOS or set caps event comes.
Rather than losing the last several frames, we should just give up
the backward reference here. */
if (self->num_backward_references > 0) {
GST_INFO_OBJECT (self, "num_backward_references should only be set "
"to 0 now because of the implementation limitation.");
self->num_backward_references = 0;
}
self->hcurr = -1; self->hcurr = -1;
return; return;
} }