mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-10 11:29:55 +00:00
Code Issues 1 Projects Releases Wiki Activity

gst/gstclock.c: Make some checks actually useful.

Browse source 
Original commit message from CVS:
* gst/gstclock.c: (gst_clock_set_calibration):
Make some checks actually useful.
* gst/gstregistrybinary.c: (gst_registry_binary_load_plugin):
Remove some unused code. Unsigned integers tend to be >= 0.
This commit is contained in:
Sebastian Dröge 2008-05-04 14:25:07 +00:00
parent aac27f1d5f
commit a8d43712da
3 changed files with 10 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog
View file

@ -1,3 +1,11 @@
2008-05-04 Sebastian Dröge <slomo@circular-chaos.org>
* gst/gstclock.c: (gst_clock_set_calibration):
Make some checks actually useful.
* gst/gstregistrybinary.c: (gst_registry_binary_load_plugin):
Remove some unused code. Unsigned integers tend to be >= 0.
2008-05-03 Tim-Philipp Müller <tim.muller at collabora co uk>
* gst/gstminiobject.c: (gst_value_get_mini_object):

4
gst/gstclock.c
View file

@ -932,8 +932,8 @@ gst_clock_set_calibration (GstClock * clock, GstClockTime internal, GstClockTime
external, GstClockTime rate_num, GstClockTime rate_denom)
{
g_return_if_fail (GST_IS_CLOCK (clock));
g_return_if_fail (rate_num >= 0);
g_return_if_fail (rate_denom > 0);
g_return_if_fail (rate_num != GST_CLOCK_TIME_NONE);
g_return_if_fail (rate_denom > 0 && rate_denom != GST_CLOCK_TIME_NONE);
g_return_if_fail (internal <= gst_clock_get_internal_time (clock));
GST_OBJECT_LOCK (clock);

10
gst/gstregistrybinary.c
View file

@ -994,16 +994,6 @@ gst_registry_binary_load_plugin (GstRegistry * registry, gchar ** in)
GST_LOG ("Reading/casting for GstBinaryPluginElement at address %p", *in);
unpack_element (*in, pe, GstBinaryPluginElement);
if (pe->nfeatures < 0) {
GST_ERROR ("The number of feature structure is not valid !");
return FALSE;
}
if (pe->file_mtime < 0 || pe->file_size < 0) {
GST_ERROR ("Plugin time or file size is not valid !");
return FALSE;
}
plugin = g_object_new (GST_TYPE_PLUGIN, NULL);
/* TODO: also set GST_PLUGIN_FLAG_CONST */