mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 05:06:17 +00:00
Code Issues 1 Projects Releases Wiki Activity

tsdemux: Handle PCR-less streams

Browse source 
Some programs specify a PCR PID but don't actually store any PCR values, or are
way too far apart.

In order to gracefully handle those situations, we will queue up to a certain
amount of pending buffers before deciding to give up on that PCR PID and not use
any (i.e. using DTS/PTS values as-is)

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1629

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2422>
This commit is contained in:
Edward Hervey 2021-07-22 15:14:26 +02:00 committed by Edward Hervey
parent 0c8d41b8b0
commit a79a756b79
1 changed files with 30 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
gst/mpegtsdemux/tsdemux.c
View file

@ -2261,6 +2261,7 @@ check_pending_buffers (GstTSDemux * demux)
guint64 offset = 0; guint64 offset = 0;
GList *tmp; GList *tmp;
gboolean have_only_sparse = TRUE; gboolean have_only_sparse = TRUE;
gboolean exceeded_threshold = FALSE;
/* 0. Do we only have sparse stream */ /* 0. Do we only have sparse stream */
for (tmp = demux->program->stream_list; tmp; tmp = tmp->next) { for (tmp = demux->program->stream_list; tmp; tmp = tmp->next) {
@ -2282,12 +2283,38 @@ check_pending_buffers (GstTSDemux * demux)
have_observation = TRUE; have_observation = TRUE;
break; break;
} }
/* 1.2 Check if we exceeded the maximum threshold of pending data */
if (tmpstream->pending && (tmpstream->raw_dts != -1
|| tmpstream->raw_pts != -1)) {
PendingBuffer *pend = tmpstream->pending->data;
guint64 lastval =
tmpstream->raw_dts != -1 ? tmpstream->raw_dts : tmpstream->raw_pts;
guint64 firstval = pend->dts != -1 ? pend->dts : pend->pts;
GstClockTime dur;
g_assert (firstval != -1);
dur = MPEGTIME_TO_GSTTIME (lastval - firstval);
GST_DEBUG_OBJECT (tmpstream->pad,
"Pending content duration: %" GST_TIME_FORMAT, GST_TIME_ARGS (dur));
if (dur > 500 * GST_MSECOND) {
exceeded_threshold = TRUE;
break;
}
}
} }
} }
/* 2. If we don't have a valid value yet, break out */ if (have_observation == FALSE) {
if (have_observation == FALSE) /* 2. If we don't have a valid value yet, break out */
return FALSE; if (!exceeded_threshold)
return FALSE;
/* Except if we've exceed the maximum amount of pending buffers, in which
* case we ignore PCR from now on */
GST_DEBUG_OBJECT (demux,
"Saw more than 500ms of data without PCR. Ignoring PCR from now on");
GST_MPEGTS_BASE (demux)->ignore_pcr = TRUE;
demux->program->pcr_pid = 0x1fff;
}
/* 3. Go over all streams that have current/pending data */ /* 3. Go over all streams that have current/pending data */
for (tmp = demux->program->stream_list; tmp; tmp = tmp->next) { for (tmp = demux->program->stream_list; tmp; tmp = tmp->next) {