mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-20 07:16:55 +00:00
Code Issues 1 Projects Releases Wiki Activity

check: don't memcmp twice

Browse source 
Simply call fail() in the condition after the first memcmp.
This commit is contained in:
Stefan Sauer 2015-12-27 19:42:37 +01:00
parent a65e18d890
commit a6e72aa28f
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libs/gst/check/gstcheck.c
View file

@ -421,7 +421,7 @@ gst_check_setup_sink_pad (GstElement * element, GstStaticPadTemplate * tmpl)
* @tmpl: pad template * @tmpl: pad template
* @name: Name of the @element src pad that will be linked to the sink pad that will be setup * @name: Name of the @element src pad that will be linked to the sink pad that will be setup
* *
* Creates a new sink pad (based on the given @tmpl) and links it to the given @element src pad * Creates a new sink pad (based on the given @tmpl) and links it to the given @element src pad
* (the pad that matches the given @name). * (the pad that matches the given @name).
* You can set event/chain/query functions on this pad to check the output of the @element. * You can set event/chain/query functions on this pad to check the output of the @element.
* *
@ -559,9 +559,8 @@ gst_check_buffer_data (GstBuffer * buffer, gconstpointer data, gsize size)
gst_util_dump_mem (info.data, info.size); gst_util_dump_mem (info.data, info.size);
g_print ("\nExpected data:\n"); g_print ("\nExpected data:\n");
gst_util_dump_mem (data, size); gst_util_dump_mem (data, size);
fail ("buffer contents not equal");
} }
fail_unless (memcmp (info.data, data, size) == 0,
"buffer contents not equal");
gst_buffer_unmap (buffer, &info); gst_buffer_unmap (buffer, &info);
} }