mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-24 15:06:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

tracers: log: Fix wrong argument in do_chain_buffer_pre()

Browse source 
The third argument of the pad-chain-pre and pad-chain-post hooks are of type GstBuffer* and GstBufferList* respectively.

However, when I added do_chain_buffer_pre() and do_chain_buffer_post()
to gstlog.c I accidentally make them take GstFlowReturn -- almost
certainly as an artifact from duplicating the code of the _post()
variants, leading to erroneous log lines like this:

```
do_chain_buffer_pre:<vp9parse0:sink> 0:00:01.615378540, pad=<vp9parse0:sink>, res=-1073639680
```

This patch fixes that.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8366>
This commit is contained in:
Alicia Boya García 2025-01-27 14:44:02 +01:00
parent 6d9552295f
commit a6dcbf9446
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
subprojects/gstreamer/plugins/tracers/gstlog.c
View file

@ -193,11 +193,11 @@ do_push_buffer_list_post (GstTracer * self, guint64 ts, GstPad * pad,
static void static void
do_chain_buffer_pre (GstTracer * self, guint64 ts, GstPad * pad, do_chain_buffer_pre (GstTracer * self, guint64 ts, GstPad * pad,
GstFlowReturn res) GstBuffer * buffer)
{ {
do_log (GST_CAT_BUFFER, GST_FUNCTION, (GObject *) pad, do_log (GST_CAT_BUFFER, GST_FUNCTION, (GObject *) pad,
"%" GST_TIME_FORMAT ", pad=%" GST_PTR_FORMAT ", res=%d", "%" GST_TIME_FORMAT ", pad=%" GST_PTR_FORMAT ", buffer=%" GST_PTR_FORMAT,
GST_TIME_ARGS (ts), pad, res); GST_TIME_ARGS (ts), pad, buffer);
} }
static void static void
@ -211,11 +211,11 @@ do_chain_buffer_post (GstTracer * self, guint64 ts, GstPad * pad,
static void static void
do_chain_buffer_list_pre (GstTracer * self, guint64 ts, GstPad * pad, do_chain_buffer_list_pre (GstTracer * self, guint64 ts, GstPad * pad,
GstFlowReturn res) GstBufferList * list)
{ {
do_log (GST_CAT_BUFFER_LIST, GST_FUNCTION, (GObject *) pad, do_log (GST_CAT_BUFFER_LIST, GST_FUNCTION, (GObject *) pad,
"%" GST_TIME_FORMAT ", pad=%" GST_PTR_FORMAT ", res=%d", "%" GST_TIME_FORMAT ", pad=%" GST_PTR_FORMAT ", list=%p",
GST_TIME_ARGS (ts), pad, res); GST_TIME_ARGS (ts), pad, list);
} }
static void static void