mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-13 10:55:34 +00:00
Code Issues 1 Projects Releases Wiki Activity

multiqueue: never unref queries we do not own

Browse source 
The `query` argument of gst_pad_query is "transfer none".

Query objects are "borrowed" by the pad query handlers and those
should never unref them.

This was leading to double freed queries in a very racy way with nested
GESTimelines.
This commit is contained in:
Thibault Saunier 2019-06-19 23:29:24 -04:00 committed by Tim-Philipp Müller
parent 80c5dacfb3
commit a5d22be74b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/elements/gstmultiqueue.c
View file

@ -2049,7 +2049,7 @@ next:
out_flushing:
{
if (object)
if (object && !GST_IS_QUERY (object))
gst_mini_object_unref (object);
GST_MULTI_QUEUE_MUTEX_LOCK (mq);