mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-20 00:31:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

gl/wayland: call eglTerminate() before wl_display_disconnect()

Browse source 
Calling these two functions in the wrong order will result in
use-after-free inside wayland.

https://bugzilla.gnome.org/show_bug.cgi?id=787293
This commit is contained in:
Matthew Waters 2017-09-05 16:14:02 +10:00 committed by Tim-Philipp Müller
parent 143f9abf49
commit a5aff145a2
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst-libs/gst/gl/wayland/gstgldisplay_wayland.c
View file

@ -91,6 +91,10 @@ gst_gl_display_wayland_finalize (GObject * object)
{ {
GstGLDisplayWayland *display_wayland = GST_GL_DISPLAY_WAYLAND (object); GstGLDisplayWayland *display_wayland = GST_GL_DISPLAY_WAYLAND (object);
/* Cause eglTerminate() to occur before wl_display_disconnect()
* https://bugzilla.gnome.org/show_bug.cgi?id=787293 */
g_object_set_data (object, "gst.gl.display.egl", NULL);
if (!display_wayland->foreign_display && display_wayland->display) { if (!display_wayland->foreign_display && display_wayland->display) {
wl_display_flush (display_wayland->display); wl_display_flush (display_wayland->display);
wl_display_disconnect (display_wayland->display); wl_display_disconnect (display_wayland->display);