mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 12:11:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

rtpvrawpay: guard against pathological "no space" condition

Browse source 
Even if one woul hope one pixel can fit in a MTU, ensure we do not
overwrite a buffer if this is not the case.

Spotted while looking at Coverity 1208786
This commit is contained in:
Vincent Penquerc'h 2014-04-30 14:50:44 +01:00
parent dfa2df1c88
commit a55b8e9c00
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gst/rtp/gstrtpvrawpay.c
View file

@ -331,6 +331,13 @@ gst_rtp_vraw_pay_handle_buffer (GstRTPBasePayload * payload, GstBuffer * buffer)
/* the headers start here */ /* the headers start here */
headers = outdata; headers = outdata;
/* make sure we can fit at least *one* header and pixel */
if (!(left > (6 + pgroup))) {
gst_rtp_buffer_unmap (&rtp);
gst_buffer_unref (out);
goto too_small;
}
/* while we can fit at least one header and one pixel */ /* while we can fit at least one header and one pixel */
while (left > (6 + pgroup)) { while (left > (6 + pgroup)) {
/* we need a 6 bytes header */ /* we need a 6 bytes header */
@ -516,6 +523,14 @@ unknown_sampling:
gst_buffer_unref (buffer); gst_buffer_unref (buffer);
return GST_FLOW_NOT_SUPPORTED; return GST_FLOW_NOT_SUPPORTED;
} }
too_small:
{
GST_ELEMENT_ERROR (payload, RESOURCE, NO_SPACE_LEFT,
(NULL), ("not enough space to send at least one pixel"));
gst_video_frame_unmap (&frame);
gst_buffer_unref (buffer);
return GST_FLOW_NOT_SUPPORTED;
}
} }
gboolean gboolean