mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-31 19:42:26 +00:00
Code Issues 1 Projects Releases Wiki Activity

vaapidecode: expose raw src caps with same chroma

Browse source 
The try-and-error approach for getting the possible image formats from
a surface has brought several problems in different drivers, from
crashes to drop in performance.

Instead of that we change the algorithm to determine the possible
image formats based in the surface chroma: only those available image
formats with same chroma are exposed as possible raw caps.

Do this is important to avoid performance degrading in raw sinks
which doesn't handle NV12 but it does YV12 or I420.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/381>
This commit is contained in:
Víctor Manuel Jáquez Leal 2020-08-12 17:50:50 +02:00
parent 30290115af
commit a50b466fc7
1 changed files with 41 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
gst/vaapi/gstvaapidecode.c
View file

@ -200,6 +200,7 @@ gst_vaapidecode_update_sink_caps (GstVaapiDecode * decode, GstCaps * caps)
static gboolean static gboolean
gst_vaapidecode_ensure_allowed_srcpad_caps (GstVaapiDecode * decode) gst_vaapidecode_ensure_allowed_srcpad_caps (GstVaapiDecode * decode)
{ {
GstVaapiDisplay *const display = GST_VAAPI_PLUGIN_BASE_DISPLAY (decode);
GstCaps *out_caps, *raw_caps, *va_caps, *dma_caps, *gltexup_caps, *base_caps; GstCaps *out_caps, *raw_caps, *va_caps, *dma_caps, *gltexup_caps, *base_caps;
GArray *formats; GArray *formats;
gint min_width, min_height, max_width, max_height; gint min_width, min_height, max_width, max_height;
@ -209,7 +210,7 @@ gst_vaapidecode_ensure_allowed_srcpad_caps (GstVaapiDecode * decode)
if (decode->allowed_srcpad_caps) if (decode->allowed_srcpad_caps)
return TRUE; return TRUE;
if (!GST_VAAPI_PLUGIN_BASE_DISPLAY (decode)) if (!display)
return FALSE; return FALSE;
if (!decode->decoder) if (!decode->decoder)
@ -228,14 +229,41 @@ gst_vaapidecode_ensure_allowed_srcpad_caps (GstVaapiDecode * decode)
gst_vaapi_caps_set_width_and_height_range (base_caps, min_width, min_height, gst_vaapi_caps_set_width_and_height_range (base_caps, min_width, min_height,
max_width, max_height); max_width, max_height);
raw_caps = gst_vaapi_plugin_base_get_allowed_srcpad_raw_caps {
(GST_VAAPI_PLUGIN_BASE (decode), GArray *img_formats = gst_vaapi_display_get_image_formats (display);
GST_VIDEO_INFO_FORMAT (&decode->decoded_info)); GstVideoFormat decoded_format =
if (!raw_caps) GST_VIDEO_INFO_FORMAT (&decode->decoded_info);
goto bail;
raw_caps = gst_caps_copy (raw_caps); if (!img_formats)
gst_vaapi_caps_set_width_and_height_range (raw_caps, min_width, min_height, img_formats = g_array_ref (formats);
max_width, max_height);
if (decoded_format != GST_VIDEO_FORMAT_UNKNOWN) {
guint decoded_chroma =
gst_vaapi_video_format_get_chroma_type (decoded_format);
GArray *new_img_formats =
g_array_new (FALSE, FALSE, sizeof (GstVideoFormat));
gint i;
for (i = 0; i < img_formats->len; i++) {
const GstVideoFormat fmt =
g_array_index (img_formats, GstVideoFormat, i);
if (gst_vaapi_video_format_get_chroma_type (fmt) == decoded_chroma)
g_array_append_val (new_img_formats, fmt);
}
if (new_img_formats->len == 0) {
g_clear_pointer (&new_img_formats, g_array_unref);
} else {
g_clear_pointer (&img_formats, g_array_unref);
img_formats = new_img_formats;
}
}
raw_caps = gst_vaapi_video_format_new_template_caps_from_list (img_formats);
gst_vaapi_caps_set_width_and_height_range (raw_caps, min_width, min_height,
max_width, max_height);
g_array_unref (img_formats);
}
va_caps = gst_caps_copy (base_caps); va_caps = gst_caps_copy (base_caps);
gst_caps_set_features_simple (va_caps, gst_caps_set_features_simple (va_caps,
@ -447,6 +475,10 @@ is_surface_resolution_changed (GstVaapiDecode * decode,
surface_format = GST_VIDEO_FORMAT_NV12; surface_format = GST_VIDEO_FORMAT_NV12;
} }
/* reset allowed source caps since they are dependant of the decoded
* surface format */
gst_caps_replace (&decode->allowed_srcpad_caps, NULL);
gst_video_info_set_format (vinfo, surface_format, surface_width, gst_video_info_set_format (vinfo, surface_format, surface_width,
surface_height); surface_height);