mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-26 19:51:11 +00:00
Code Issues 1 Projects Releases Wiki Activity

fpsdisplaysink: Minor fixes

Browse source 
Downgrade a warning message to debug. Remove an
already fixed FIXME and add a note about (not-)using
fpsdisplaysink in autovideosink. Change the created
ghostpad to use the name "sink" as it is advertised in
the pad template.
This commit is contained in:
Thiago Santos 2009-12-17 07:54:04 -03:00
parent 86c2660d8d
commit a4f30d5f3d
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gst/debugutils/fpsdisplaysink.c
View file

@ -34,7 +34,12 @@
/* FIXME: /* FIXME:
* - can we avoid plugging the textoverlay? * - can we avoid plugging the textoverlay?
* - gst-seek 15 "videotestsrc ! fpsdisplaysink" dies when closing gst-seek * - gst-seek 15 "videotestsrc ! fpsdisplaysink" dies when closing gst-seek
* - if we make ourself RANK_PRIMARY+10 autovideosink asserts *
* NOTE:
* - if we make ourself RANK_PRIMARY+10 or something that autovideosink would
* select and fpsdisplaysink is set to use autovideosink as its internal sink
* it doesn't work. Reason: autovideosink creates a fpsdisplaysink, that
* creates an autovideosink, that...
* *
* IDEAS: * IDEAS:
* - do we want to gather min/max fps and show in GST_STATE_CHANGE_READY_TO_NULL * - do we want to gather min/max fps and show in GST_STATE_CHANGE_READY_TO_NULL
@ -230,7 +235,7 @@ update_video_sink (GstFPSDisplaySink * self, GstElement * video_sink)
gst_bin_add (GST_BIN (self), self->video_sink); gst_bin_add (GST_BIN (self), self->video_sink);
/* create ghost pad */ /* create ghost pad */
self->ghost_pad = gst_ghost_pad_new_no_target ("sink_pad", GST_PAD_SINK); self->ghost_pad = gst_ghost_pad_new_no_target ("sink", GST_PAD_SINK);
gst_element_add_pad (GST_ELEMENT (self), self->ghost_pad); gst_element_add_pad (GST_ELEMENT (self), self->ghost_pad);
/* attach or pad probe */ /* attach or pad probe */
@ -318,7 +323,7 @@ fps_display_sink_start (GstFPSDisplaySink * self)
self->frames_rendered = G_GUINT64_CONSTANT (0); self->frames_rendered = G_GUINT64_CONSTANT (0);
self->frames_dropped = G_GUINT64_CONSTANT (0); self->frames_dropped = G_GUINT64_CONSTANT (0);
GST_WARNING ("use text-overlay? %d", self->use_text_overlay); GST_DEBUG_OBJECT (self, "Use text-overlay? %d", self->use_text_overlay);
if (self->use_text_overlay) { if (self->use_text_overlay) {
if (!self->text_overlay) { if (!self->text_overlay) {