mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-06-29 11:20:43 +00:00
Code Issues 1 Projects Releases Wiki Activity

Make sure that unlinked pads do not cause a return false on latency events.

Browse source 
Context: Latency configuration should not be
messed up because of not-linked pads. In general,
one return FALSE on latency distribution causes
the "overall" pipeline latency configuration to
fail. This shows up as noise in logs (warning).
This commit is contained in:
Havard Graff 2009-10-13 17:24:34 +02:00 committed by Wim Taymans
parent 9760c012f6
commit a4b9b79c96
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
gst/gstpad.c
View file

@ -5206,6 +5206,7 @@ gst_pad_push_event (GstPad * pad, GstEvent * event)
{
GstPad *peerpad;
gboolean result;
gboolean is_latency = FALSE;
g_return_val_if_fail (GST_IS_PAD (pad), FALSE);
g_return_val_if_fail (event != NULL, FALSE);
@ -5242,6 +5243,8 @@ gst_pad_push_event (GstPad * pad, GstEvent * event)
goto flushed;
}
break;
case GST_EVENT_LATENCY:
is_latency = TRUE;
default:
while (G_UNLIKELY (GST_PAD_IS_BLOCKED (pad))) {
/* block the event as long as the pad is blocked */
@ -5295,6 +5298,10 @@ not_linked:
GST_DEBUG_OBJECT (pad, "Dropping event because pad is not linked");
gst_event_unref (event);
GST_OBJECT_UNLOCK (pad);
if (is_latency) /* unlinked pads should not influence latency configuration */
return TRUE;
return FALSE;
}
flushed: