mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-28 19:20:35 +00:00
Code Issues 1 Projects Releases Wiki Activity

audioamplify: Fix integer overflows on 32 bit architectures

Browse source
This commit is contained in:
Sebastian Dröge 2009-06-21 17:13:43 +02:00
parent f80b62c3db
commit a3cb8f005b
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
gst/audiofx/audioamplify.c
View file

@ -155,7 +155,7 @@ static GstFlowReturn gst_audio_amplify_transform_ip (GstBaseTransform * base,
#define MIN_gint32 G_MININT32
#define MAX_gint32 G_MAXINT32
#define MAKE_INT_FUNCS(type) \
#define MAKE_INT_FUNCS(type,largetype) \
static void \
gst_audio_amplify_transform_##type##_clip (GstAudioAmplify * filter, \
void * data, guint num_samples) \
@ -163,7 +163,7 @@ gst_audio_amplify_transform_##type##_clip (GstAudioAmplify * filter, \
type *d = data; \
\
while (num_samples--) { \
glong val = *d * filter->amplification; \
largetype val = *d * filter->amplification; \
*d++ = CLAMP (val, MIN_##type, MAX_##type); \
} \
} \
@ -174,12 +174,12 @@ gst_audio_amplify_transform_##type##_wrap_negative (GstAudioAmplify * filter, \
type *d = data; \
\
while (num_samples--) { \
glong val = *d * filter->amplification; \
largetype val = *d * filter->amplification; \
if (val > MAX_##type) \
val = MIN_##type + (val - MIN_##type) % ((glong) MAX_##type + 1 - \
val = MIN_##type + (val - MIN_##type) % ((largetype) MAX_##type + 1 - \
MIN_##type); \
else if (val < MIN_##type) \
val = MAX_##type - (MAX_##type - val) % ((glong) MAX_##type + 1 - \
val = MAX_##type - (MAX_##type - val) % ((largetype) MAX_##type + 1 - \
MIN_##type); \
*d++ = val; \
} \
@ -191,7 +191,7 @@ gst_audio_amplify_transform_##type##_wrap_positive (GstAudioAmplify * filter, \
type *d = data; \
\
while (num_samples--) { \
glong val = *d * filter->amplification; \
largetype val = *d * filter->amplification; \
do { \
if (val > MAX_##type) \
val = MAX_##type - (val - MAX_##type); \
@ -274,9 +274,9 @@ gst_audio_amplify_transform_##type##_noclip (GstAudioAmplify * filter, \
}
/* *INDENT-OFF* */
MAKE_INT_FUNCS (gint8)
MAKE_INT_FUNCS (gint16)
MAKE_INT_FUNCS (gint32)
MAKE_INT_FUNCS (gint8,gint)
MAKE_INT_FUNCS (gint16,gint)
MAKE_INT_FUNCS (gint32,gint64)
MAKE_FLOAT_FUNCS (gfloat)
MAKE_FLOAT_FUNCS (gdouble)
/* *INDENT-ON* */