mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-22 05:56:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

playbin2: Make sure that the decoders we plug are compatible with the fixed sink

Browse source 
The fact that a decoder is not compatible with the fixed sink
is currently happenning in the case where we have hardware accelerated
video decoders on the system (especially vaapi elements that are actually plugged),
and the user is providing a sink that doesn't support the surface.

A simple example that shows how it used to crash on a system where gstreamer-vaapi
is installed:
    gst-launch playbin2 video-sink=xvimagesink uri=/codec/supported/by/vaapi

What we are now doing in this case, is avoid using the accelerated
decoder and plug a "normal" decoder instead (if avalaible).

This commit doesn't handle the case where we have hardware accelerated
demuxing.
This commit is contained in:
Thibault Saunier 2011-09-30 12:29:34 -03:00 committed by Sebastian Dröge
parent 93900d47ed
commit a123195dd0
1 changed files with 48 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
gst/playback/gstplaybin2.c
View file

@ -3221,10 +3221,55 @@ autoplug_select_cb (GstElement * decodebin, GstPad * pad,
GST_DEBUG_OBJECT (playbin, "checking factory %s",
GST_PLUGIN_FEATURE_NAME (factory));
/* if it's not a sink, we just make decodebin try it */
/* if it's not a sink, we make sure the element is compatible with
* the fixed sink */
if (!gst_element_factory_list_is_type (factory,
GST_ELEMENT_FACTORY_TYPE_SINK))
return GST_AUTOPLUG_SELECT_TRY;
GST_ELEMENT_FACTORY_TYPE_SINK)) {
gboolean isvideodec = gst_element_factory_list_is_type (factory,
GST_ELEMENT_FACTORY_TYPE_DECODER |
GST_ELEMENT_FACTORY_TYPE_MEDIA_VIDEO);
gboolean isimagedec = gst_element_factory_list_is_type (factory,
GST_ELEMENT_FACTORY_TYPE_DECODER |
GST_ELEMENT_FACTORY_TYPE_MEDIA_IMAGE);
gboolean isaudiodec = gst_element_factory_list_is_type (factory,
GST_ELEMENT_FACTORY_TYPE_DECODER |
GST_ELEMENT_FACTORY_TYPE_MEDIA_AUDIO);
/* If it is a decoder and we have a fixed sink for the media
* type it outputs, check that the decoder is compatible with this sink */
if (((isvideodec || isimagedec) && group->video_sink) ||
(isaudiodec && group->audio_sink)) {
gboolean compatible = TRUE;
GstPad *sinkpad;
GstCaps *caps;
GstElement *sink;
if (isaudiodec)
sink = group->audio_sink;
else
sink = group->video_sink;
if ((sinkpad = gst_element_get_static_pad (sink, "sink"))) {
caps = gst_pad_get_caps_reffed (sinkpad);
compatible = gst_element_factory_can_src_any_caps (factory, caps);
gst_object_unref (sinkpad);
gst_caps_unref (caps);
}
if (compatible)
return GST_AUTOPLUG_SELECT_TRY;
GST_DEBUG_OBJECT (playbin, "%s not compatible with the fixed sink",
GST_PLUGIN_FEATURE_NAME (factory));
return GST_AUTOPLUG_SELECT_SKIP;
} else
return GST_AUTOPLUG_SELECT_TRY;
}
/* it's a sink, see if an instance of it actually works */
GST_DEBUG_OBJECT (playbin, "we found a sink");