ext/: Fix various compiler warnings that reveal potential bugs.

Original commit message from CVS:
2007-01-04  Julien MOUTTE  <julien@moutte.net>

* ext/directfb/dfbvideosink.c:
(gst_dfbvideosink_navigation_send_event),
(gst_dfbvideosink_get_type):
* ext/sdl/sdlaudiosink.c: (gst_sdlaudio_sink_open):
* ext/sdl/sdlvideosink.c: (gst_sdlvideosink_setcaps),
(gst_sdlvideosink_show_frame),
(gst_sdlvideosink_navigation_send_event):
* ext/sdl/sdlvideosink.h: Fix various compiler warnings that
reveal potential bugs.
This commit is contained in:
Julien Moutte 2007-01-04 09:51:56 +00:00
parent e2117c6c67
commit a0552f1769
5 changed files with 20 additions and 11 deletions

View file

@ -1,3 +1,15 @@
2007-01-04 Julien MOUTTE <julien@moutte.net>
* ext/directfb/dfbvideosink.c:
(gst_dfbvideosink_navigation_send_event),
(gst_dfbvideosink_get_type):
* ext/sdl/sdlaudiosink.c: (gst_sdlaudio_sink_open):
* ext/sdl/sdlvideosink.c: (gst_sdlvideosink_setcaps),
(gst_sdlvideosink_show_frame),
(gst_sdlvideosink_navigation_send_event):
* ext/sdl/sdlvideosink.h: Fix various compiler warnings that
reveal potential bugs.
2007-01-04 Tim-Philipp Müller <tim at centricular dot net> 2007-01-04 Tim-Philipp Müller <tim at centricular dot net>
Patch by: Vincent Torri <vtorri at univ-evry fr> Patch by: Vincent Torri <vtorri at univ-evry fr>

View file

@ -1942,7 +1942,6 @@ gst_dfbvideosink_navigation_send_event (GstNavigation * navigation,
GstDfbVideoSink *dfbvideosink = GST_DFBVIDEOSINK (navigation); GstDfbVideoSink *dfbvideosink = GST_DFBVIDEOSINK (navigation);
GstEvent *event; GstEvent *event;
GstVideoRectangle src, dst, result; GstVideoRectangle src, dst, result;
gint width, height;
double x, y; double x, y;
GstPad *pad = NULL; GstPad *pad = NULL;
@ -2366,6 +2365,11 @@ gst_dfbvideosink_get_type (void)
NULL, NULL,
NULL, NULL,
}; };
static const GInterfaceInfo colorbalance_info = {
(GInterfaceInitFunc) gst_dfbvideosink_colorbalance_init,
NULL,
NULL,
};
dfbvideosink_type = g_type_register_static (GST_TYPE_VIDEO_SINK, dfbvideosink_type = g_type_register_static (GST_TYPE_VIDEO_SINK,
"GstDfbVideoSink", &dfbvideosink_info, 0); "GstDfbVideoSink", &dfbvideosink_info, 0);
@ -2374,6 +2378,8 @@ gst_dfbvideosink_get_type (void)
GST_TYPE_IMPLEMENTS_INTERFACE, &iface_info); GST_TYPE_IMPLEMENTS_INTERFACE, &iface_info);
g_type_add_interface_static (dfbvideosink_type, GST_TYPE_NAVIGATION, g_type_add_interface_static (dfbvideosink_type, GST_TYPE_NAVIGATION,
&navigation_info); &navigation_info);
g_type_add_interface_static (dfbvideosink_type, GST_TYPE_COLOR_BALANCE,
&colorbalance_info);
} }
return dfbvideosink_type; return dfbvideosink_type;

View file

@ -35,11 +35,6 @@ GST_ELEMENT_DETAILS ("SDL audio sink",
static void gst_sdlaudio_sink_dispose (GObject * object); static void gst_sdlaudio_sink_dispose (GObject * object);
static void gst_sdlaudio_sink_get_property (GObject * object, guint prop_id,
GValue * value, GParamSpec * pspec);
static void gst_sdlaudio_sink_set_property (GObject * object, guint prop_id,
const GValue * value, GParamSpec * pspec);
static GstCaps *gst_sdlaudio_sink_getcaps (GstBaseSink * bsink); static GstCaps *gst_sdlaudio_sink_getcaps (GstBaseSink * bsink);
static gboolean gst_sdlaudio_sink_open (GstAudioSink * asink); static gboolean gst_sdlaudio_sink_open (GstAudioSink * asink);
@ -258,7 +253,6 @@ static gboolean
gst_sdlaudio_sink_open (GstAudioSink * asink) gst_sdlaudio_sink_open (GstAudioSink * asink)
{ {
GstSDLAudioSink *sdlaudio; GstSDLAudioSink *sdlaudio;
int mode;
sdlaudio = GST_SDLAUDIOSINK (asink); sdlaudio = GST_SDLAUDIOSINK (asink);

View file

@ -717,7 +717,6 @@ static gboolean
gst_sdlvideosink_setcaps (GstBaseSink * bsink, GstCaps * vscapslist) gst_sdlvideosink_setcaps (GstBaseSink * bsink, GstCaps * vscapslist)
{ {
GstSDLVideoSink *sdlvideosink; GstSDLVideoSink *sdlvideosink;
guint32 format;
GstStructure *structure; GstStructure *structure;
gboolean res = TRUE; gboolean res = TRUE;
@ -746,7 +745,6 @@ gst_sdlvideosink_show_frame (GstBaseSink * bsink, GstBuffer * buf)
{ {
GstSDLVideoSink *sdlvideosink; GstSDLVideoSink *sdlvideosink;
SDL_Event sdl_event;
sdlvideosink = GST_SDLVIDEOSINK (bsink); sdlvideosink = GST_SDLVIDEOSINK (bsink);
@ -948,7 +946,6 @@ gst_sdlvideosink_navigation_send_event (GstNavigation * navigation,
GstSDLVideoSink *sdlvideosink = GST_SDLVIDEOSINK (navigation); GstSDLVideoSink *sdlvideosink = GST_SDLVIDEOSINK (navigation);
GstEvent *event; GstEvent *event;
GstVideoRectangle src, dst, result; GstVideoRectangle src, dst, result;
gint width, height;
double x, y; double x, y;
GstPad *pad = NULL; GstPad *pad = NULL;

View file

@ -75,7 +75,7 @@ struct _GstSDLVideoSinkClass {
}; };
GType gst_sdlsink_get_type(void); GType gst_sdlvideosink_get_type(void);
G_END_DECLS G_END_DECLS