mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-10-03 18:49:46 +00:00
Code Issues 1 Projects Releases Wiki Activity

gstinfo: Optimize color escape code creation

Browse source 
When coloring is in use, those escape codes are going to be created many times
for almost all debug lines.

Don't create plenty of temporary allocations, and instead build the escape code
ourselves statically

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3498>
This commit is contained in:
Edward Hervey 2022-12-01 08:16:45 +01:00 committed by GStreamer Marge Bot
parent 4b96294f19
commit 9f9e625776
1 changed files with 36 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
subprojects/gstreamer/gst/gstinfo.c
View file

@ -1044,6 +1044,37 @@ gst_info_printf_pointer_extension_func (const char *format, void *ptr)
return s; return s;
} }
/* Allocation-less generator of color escape code. Provide a 20 byte write
* area */
static void
_construct_term_color (guint colorinfo, gchar write_area[20])
{
guint offset;
memcpy (write_area, "\033[00", 4);
offset = 4;
if (colorinfo & GST_DEBUG_BOLD) {
memcpy (write_area + offset, ";01", 3);
offset += 3;
}
if (colorinfo & GST_DEBUG_UNDERLINE) {
memcpy (write_area + offset, ";04", 3);
offset += 3;
}
if (colorinfo & GST_DEBUG_FG_MASK) {
memcpy (write_area + offset, ";3", 2);
write_area[offset + 2] = '0' + (colorinfo & GST_DEBUG_FG_MASK);
offset += 3;
}
if (colorinfo & GST_DEBUG_BG_MASK) {
memcpy (write_area + offset, ";4", 2);
write_area[offset + 2] = '0' + ((colorinfo & GST_DEBUG_BG_MASK) >> 4);
offset += 3;
}
strncpy (write_area + offset, "m", 2);
}
/** /**
* gst_debug_construct_term_color: * gst_debug_construct_term_color:
* @colorinfo: the color info * @colorinfo: the color info
@ -1058,26 +1089,11 @@ gst_info_printf_pointer_extension_func (const char *format, void *ptr)
gchar * gchar *
gst_debug_construct_term_color (guint colorinfo) gst_debug_construct_term_color (guint colorinfo)
{ {
GString *color; gchar tmp_color[20];
color = g_string_new ("\033[00"); _construct_term_color (colorinfo, tmp_color);
if (colorinfo & GST_DEBUG_BOLD) { return g_strdup (tmp_color);
g_string_append_len (color, ";01", 3);
}
if (colorinfo & GST_DEBUG_UNDERLINE) {
g_string_append_len (color, ";04", 3);
}
if (colorinfo & GST_DEBUG_FG_MASK) {
g_string_append_printf (color, ";3%1d", colorinfo & GST_DEBUG_FG_MASK);
}
if (colorinfo & GST_DEBUG_BG_MASK) {
g_string_append_printf (color, ";4%1d",
(colorinfo & GST_DEBUG_BG_MASK) >> 4);
}
g_string_append_c (color, 'm');
return g_string_free (color, FALSE);
} }
/** /**
@ -1374,13 +1390,12 @@ gst_debug_log_default (GstDebugCategory * category, GstDebugLevel level,
if (color_mode == GST_DEBUG_COLOR_MODE_UNIX) { if (color_mode == GST_DEBUG_COLOR_MODE_UNIX) {
#endif #endif
/* colors, non-windows */ /* colors, non-windows */
gchar *color = NULL; gchar color[20];
const gchar *clear; const gchar *clear;
gchar pidcolor[10]; gchar pidcolor[10];
const gchar *levelcolor; const gchar *levelcolor;
color = gst_debug_construct_term_color (gst_debug_category_get_color _construct_term_color (gst_debug_category_get_color (category), color);
(category));
clear = "\033[00m"; clear = "\033[00m";
g_sprintf (pidcolor, "\033[%02dm", pid % 6 + 31); g_sprintf (pidcolor, "\033[%02dm", pid % 6 + 31);
levelcolor = levelcolormap[level]; levelcolor = levelcolormap[level];
@ -1393,7 +1408,6 @@ gst_debug_log_default (GstDebugCategory * category, GstDebugLevel level,
clear, message_str); clear, message_str);
FFLUSH_DEBUG (log_file); FFLUSH_DEBUG (log_file);
#undef PRINT_FMT #undef PRINT_FMT
g_free (color);
#ifdef G_OS_WIN32 #ifdef G_OS_WIN32
} else { } else {
/* colors, windows. */ /* colors, windows. */