mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-02 16:52:42 +00:00
Code Issues 1 Projects Releases Wiki Activity

oggdemux: fix push mode chain leak

Browse source 
When I first implemented push mode seeking, I removed the chain
freeing there as it could be used later. The current code does not
seem to do that though, so I'm restoring the previous freeing,
which plugs the leak while apparently not reintroducing use of
freed data with chained and normal files, both with gst-launch
playbin2 and Totem.
This commit is contained in:
Vincent Penquerc'h 2012-01-11 16:17:42 +00:00
parent 426f991b52
commit 9f4b71b2a7
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ext/ogg/gstoggdemux.c
View file

@ -2436,10 +2436,12 @@ gst_ogg_demux_deactivate_current_chain (GstOggDemux * ogg)
pad->added = FALSE;
}
/* With push mode seeking implemented, we can now seek back to the chain,
so we do not destroy it */
GST_DEBUG_OBJECT (ogg, "Resetting current chain");
ogg->current_chain = NULL;
/* if we cannot seek back to the chain, we can destroy the chain
* completely */
if (!ogg->pullmode) {
gst_ogg_chain_free (chain);
}
return TRUE;
}