mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-06 06:22:29 +00:00
Code Issues 1 Projects Releases Wiki Activity

validate: No execute ON_ADDITION if a previous action has a playback-time

Browse source 
As this is what user will expect in this case.

For example with this scenario:

    set-state, state=null; playback-time=5
    set-property, target-element-name=dvbsrc0, property-name=delsys, property-value=11
    play;
This commit is contained in:
Thibault Saunier 2016-06-09 16:41:57 -04:00
parent 99f9f3f408
commit 9f272556d5
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
validate/gst/validate/gst-validate-scenario.c
View file

@ -1284,9 +1284,27 @@ _fill_action (GstValidateScenario * scenario, GstValidateAction * action,
if (str_playback_time == NULL) {
GstValidateActionType *type = _find_action_type (action->type);
gboolean can_execute_on_addition =
type->flags & GST_VALIDATE_ACTION_TYPE_CAN_EXECUTE_ON_ADDITION
&& !GST_CLOCK_TIME_IS_VALID (action->playback_time);
if (type->flags & GST_VALIDATE_ACTION_TYPE_CAN_EXECUTE_ON_ADDITION
&& !GST_CLOCK_TIME_IS_VALID (action->playback_time)) {
if (priv->needs_parsing)
can_execute_on_addition = FALSE;
if (can_execute_on_addition) {
GList *tmp;
for (tmp = priv->actions; tmp; tmp = tmp->next) {
if (GST_CLOCK_TIME_IS_VALID (((GstValidateAction *) tmp->
data)->playback_time)) {
can_execute_on_addition = FALSE;
break;
}
}
}
if (can_execute_on_addition) {
SCENARIO_LOCK (scenario);
priv->on_addition_actions = g_list_append (priv->on_addition_actions,
action);