mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-25 03:01:03 +00:00
Code Issues 1 Projects Releases Wiki Activity

aggregator: don't fail all sink pads when a caps event fails negotiation

Browse source 
If one pad returns not-negotiated from a caps event, then all other sink
pads were returning not-negotiated.

In our case, we can't reliably easily fail at all so just remove that
code.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/623>
This commit is contained in:
Matthew Waters 2020-07-31 16:02:03 +10:00 committed by GStreamer Merge Bot
parent 4f95dec74a
commit 9f17094cf3
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libs/gst/base/gstaggregator.c
View file

@ -920,8 +920,6 @@ gst_aggregator_do_events_and_queries (GstElement * self, GstPad * epad,
PAD_LOCK (pad);
if (GST_EVENT_TYPE (event) == GST_EVENT_CAPS) {
pad->priv->negotiated = ret;
if (!ret)
pad->priv->flow_return = data->flow_ret = GST_FLOW_NOT_NEGOTIATED;
}
if (g_queue_peek_tail (&pad->priv->data) == event)
gst_event_unref (g_queue_pop_tail (&pad->priv->data));