mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-20 00:31:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

decodebin: don't plug the same parser multiple times in a row

Browse source 
This allows us to make parsers accept both parsed and unparsed input
without decodebin plugging them in a loop until things blow up, ie.
without affecting applications that still use the old playbin or the
old decodebin.

(Making parsers accept parsed input is useful for later when we want
to use parsers to convert the stream-format into something the decoder
can handle. It's also much more convenient for application authors
who can plug parsers unconditionally in transcoding pipelines, for
example).
This commit is contained in:
Tim-Philipp Müller 2011-07-07 15:02:19 +01:00
parent 1a8b4eae73
commit 9edbc92a27
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
gst/playback/gstdecodebin.c
View file

@ -1,5 +1,6 @@
/* GStreamer /* GStreamer
* Copyright (C) <2004> Wim Taymans <wim.taymans@gmail.com> * Copyright (C) <2004> Wim Taymans <wim.taymans@gmail.com>
* Copyright (C) 2011 Hewlett-Packard Development Company, L.P.
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public * modify it under the terms of the GNU Library General Public
@ -1115,12 +1116,26 @@ try_to_link_1 (GstDecodeBin * decode_bin, GstElement * srcelement, GstPad * pad,
/* loop over the factories */ /* loop over the factories */
for (walk = factories; walk; walk = g_list_next (walk)) { for (walk = factories; walk; walk = g_list_next (walk)) {
GstElementFactory *factory = GST_ELEMENT_FACTORY (walk->data); GstElementFactory *factory = GST_ELEMENT_FACTORY (walk->data);
GstElementFactory *src_factory;
GstElement *element; GstElement *element;
GstPadLinkReturn ret; GstPadLinkReturn ret;
GstPad *sinkpad; GstPad *sinkpad;
GST_DEBUG_OBJECT (decode_bin, "trying to link %s", GST_DEBUG_OBJECT (decode_bin, "trying to link %s to %s",
gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (factory))); gst_plugin_feature_get_name (GST_PLUGIN_FEATURE (factory)),
GST_OBJECT_NAME (srcelement));
/* don't plug the same parser twice, but allow multiple
* instances of other elements (e.g. id3demux) in a row */
src_factory = gst_element_get_factory (srcelement);
if (src_factory == factory
&& gst_element_factory_list_is_type (factory,
GST_ELEMENT_FACTORY_TYPE_PARSER)) {
GST_DEBUG_OBJECT (decode_bin,
"not inserting parser element %s twice in a row, skipping",
GST_PLUGIN_FEATURE_NAME (factory));
continue;
}
/* make an element from the factory first */ /* make an element from the factory first */
if ((element = gst_element_factory_create (factory, NULL)) == NULL) { if ((element = gst_element_factory_create (factory, NULL)) == NULL) {