mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 00:36:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

basesink/src: Post an error message if ::start() fails

Browse source 
The subclass should do that already, but just in case do it ourselves too as a
fallback. Without this, e.g. playbin will just wait forever if this fails
because it is triggered as part of an ASYNC state change.
This commit is contained in:
Sebastian Dröge 2016-05-14 17:31:51 +03:00 committed by Tim-Philipp Müller
parent 7c65287c03
commit 9dfcdec02b
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libs/gst/base/gstbasesink.c
View file

@ -5238,6 +5238,10 @@ gst_base_sink_change_state (GstElement * element, GstStateChange transition)
start_failed: start_failed:
{ {
GST_DEBUG_OBJECT (basesink, "failed to start"); GST_DEBUG_OBJECT (basesink, "failed to start");
/* subclass is supposed to post a message but we post one as a fallback
* just in case */
GST_ELEMENT_ERROR (basesink, CORE, STATE_CHANGE, (NULL),
("Failed to start"));
return GST_STATE_CHANGE_FAILURE; return GST_STATE_CHANGE_FAILURE;
} }
activate_failed: activate_failed:

5
libs/gst/base/gstbasesrc.c
View file

@ -3348,7 +3348,10 @@ was_started:
could_not_start: could_not_start:
{ {
GST_DEBUG_OBJECT (basesrc, "could not start"); GST_DEBUG_OBJECT (basesrc, "could not start");
/* subclass is supposed to post a message. We don't have to call _stop. */ /* subclass is supposed to post a message but we post one as a fallback
* just in case. We don't have to call _stop. */
GST_ELEMENT_ERROR (basesrc, CORE, STATE_CHANGE, (NULL),
("Failed to start"));
gst_base_src_start_complete (basesrc, GST_FLOW_ERROR); gst_base_src_start_complete (basesrc, GST_FLOW_ERROR);
return FALSE; return FALSE;
} }