validate: drop unneeded break+concat in some string literals

Perform other related improvements while at it.
This commit is contained in:
Reynaldo H. Verdejo Pinochet 2017-04-07 13:49:32 -07:00
parent 26b388c349
commit 9d33d0ec9c
6 changed files with 10 additions and 10 deletions

View file

@ -177,7 +177,7 @@ gst_validate_ssim_save_out (GstValidateSsim * self, GstBuffer * buffer,
if ((status = cairo_surface_write_to_png (surface, outfile)) != if ((status = cairo_surface_write_to_png (surface, outfile)) !=
CAIRO_STATUS_SUCCESS) { CAIRO_STATUS_SUCCESS) {
GST_VALIDATE_REPORT (self, GENERAL_INPUT_ERROR, GST_VALIDATE_REPORT (self, GENERAL_INPUT_ERROR,
"Could not save %s" " cairo status is %s", outfile, "Could not save '%s', cairo status is '%s'", outfile,
cairo_status_to_string (status)); cairo_status_to_string (status));
} }
@ -947,7 +947,7 @@ gst_validate_ssim_class_init (GstValidateSsimClass * klass)
g_object_class_install_property (oclass, PROP_RUNNER, g_object_class_install_property (oclass, PROP_RUNNER,
g_param_spec_object ("validate-runner", "VALIDATE Runner", g_param_spec_object ("validate-runner", "VALIDATE Runner",
"The Validate runner to " "report errors to", "The Validate runner to report errors to",
GST_TYPE_VALIDATE_RUNNER, GST_TYPE_VALIDATE_RUNNER,
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE)); G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
} }

View file

@ -175,7 +175,7 @@ gst_validate_monitor_class_init (GstValidateMonitorClass * klass)
g_object_class_install_property (gobject_class, PROP_VALIDATE_PARENT, g_object_class_install_property (gobject_class, PROP_VALIDATE_PARENT,
g_param_spec_object ("validate-parent", "VALIDATE parent monitor", g_param_spec_object ("validate-parent", "VALIDATE parent monitor",
"The Validate monitor " "that is the parent of this one", "The Validate monitor that is the parent of this one",
GST_TYPE_VALIDATE_MONITOR, GST_TYPE_VALIDATE_MONITOR,
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE)); G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
} }

View file

@ -115,7 +115,7 @@ gst_validate_override_class_init (GstValidateOverrideClass * klass)
g_object_class_install_property (oclass, PROP_RUNNER, g_object_class_install_property (oclass, PROP_RUNNER,
g_param_spec_object ("validate-runner", "VALIDATE Runner", g_param_spec_object ("validate-runner", "VALIDATE Runner",
"The Validate runner to " "report errors to", "The Validate runner to report errors to",
GST_TYPE_VALIDATE_RUNNER, GST_TYPE_VALIDATE_RUNNER,
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE)); G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
} }

View file

@ -53,7 +53,7 @@ gst_validate_reporter_default_init (GstValidateReporterInterface * iface)
{ {
g_object_interface_install_property (iface, g_object_interface_install_property (iface,
g_param_spec_object ("validate-runner", "Validate Runner", g_param_spec_object ("validate-runner", "Validate Runner",
"The Validate runner to " "report errors to", "The Validate runner to report errors to",
GST_TYPE_VALIDATE_RUNNER, GST_TYPE_VALIDATE_RUNNER,
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE)); G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
} }

View file

@ -2904,7 +2904,7 @@ gst_validate_scenario_class_init (GstValidateScenarioClass * klass)
g_object_class_install_property (object_class, PROP_RUNNER, g_object_class_install_property (object_class, PROP_RUNNER,
g_param_spec_object ("validate-runner", "VALIDATE Runner", g_param_spec_object ("validate-runner", "VALIDATE Runner",
"The Validate runner to " "report errors to", "The Validate runner to report errors to",
GST_TYPE_VALIDATE_RUNNER, GST_TYPE_VALIDATE_RUNNER,
G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE)); G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
@ -2919,7 +2919,7 @@ gst_validate_scenario_class_init (GstValidateScenarioClass * klass)
g_param_spec_boolean ("execute-on-idle", g_param_spec_boolean ("execute-on-idle",
"Force waiting between actions", "Force waiting between actions",
"Always execute actions on idle and do not chain them to execute as" "Always execute actions on idle and do not chain them to execute as"
" fast as possible. Setting this property is useful if action " " fast as possible. Setting this property is useful if action"
" execution can lead to the addition of new sources on the same main" " execution can lead to the addition of new sources on the same main"
" loop as it provides these new GSource a chance to be dispatched" " loop as it provides these new GSource a chance to be dispatched"
" between actions", FALSE, G_PARAM_READWRITE)); " between actions", FALSE, G_PARAM_READWRITE));
@ -3172,7 +3172,7 @@ gst_validate_scenario_factory_create (GstValidateRunner *
} }
if (scenario->priv->handles_state) { if (scenario->priv->handles_state) {
GST_INFO_OBJECT (scenario, "Scenario handles state," GST_INFO_OBJECT (scenario, "Scenario handles state."
" Starting the get position source"); " Starting the get position source");
_add_execute_actions_gsource (scenario); _add_execute_actions_gsource (scenario);
} }

View file

@ -212,7 +212,7 @@ runner_stopping (GstValidateRunner * runner, ValidateSsimOverride * self)
} }
gst_validate_printf (self, gst_validate_printf (self,
"Running frame comparison between images from %s and %s" "%s%s.\n", "Running frame comparison between images from '%s' and '%s' %s%s.\n",
compared_files_dir, self->priv->outdir, compared_files_dir, self->priv->outdir,
self->priv->result_outdir ? ". Issues can be visialized in " : self->priv->result_outdir ? ". Issues can be visialized in " :
" (set 'result-output-dir' in the config file to visualize the result)", " (set 'result-output-dir' in the config file to visualize the result)",
@ -607,7 +607,7 @@ _save_frame (ValidateSsimOverride * self, GstVideoFrame * frame,
if ((status = cairo_surface_write_to_png (surface, outname)) != if ((status = cairo_surface_write_to_png (surface, outname)) !=
CAIRO_STATUS_SUCCESS) { CAIRO_STATUS_SUCCESS) {
GST_VALIDATE_REPORT (self, SSIM_SAVING_ERROR, GST_VALIDATE_REPORT (self, SSIM_SAVING_ERROR,
"Could not save %s" " cairo status is %s", outname, "Could not save '%s', cairo status is '%s'", outname,
cairo_status_to_string (status)); cairo_status_to_string (status));
res = FALSE; res = FALSE;