mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-27 20:21:24 +00:00
Code Issues 1 Projects Releases Wiki Activity

vaapiupload: fix illegal write in ensure_image().

Browse source 
Fix ensure_image() to only zero-initialize the first line of each plane.
Properly initializing each plane to their full vertical resolution would
require to actually compute it based on the image format.

In particular, for NV12 images, the UV plane has half vertical resolution
vs. the Y plane. So using the full image height to initialize the UV plane
will obviously lead to a buffer overflow. Likewise for other YUV format.

Since ensure_image() is only a helper function to initialize something,
and not necessarily the whole thing, it is fine to initializ the first
line only. Besides, the target surface is not rendered either.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
This commit is contained in:
Holger Kaelberer 2013-02-26 00:38:24 +01:00 committed by Gwenole Beauchesne
parent bd3aa01de5
commit 9bf1ae04cc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/vaapi/gstvaapiuploader.c
View file

@ -108,7 +108,7 @@ ensure_image(GstVaapiImage *image)
for (i = 0; i < num_planes; i++) {
guchar * const plane = gst_vaapi_image_get_plane(image, i);
if (plane)
memset(plane, 0, height * gst_vaapi_image_get_pitch(image, i));
memset(plane, 0, gst_vaapi_image_get_pitch(image, i));
}
if (!gst_vaapi_image_unmap(image))