mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-25 01:30:38 +00:00
Code Issues 1 Projects Releases Wiki Activity

sidplay: fix compiler warnings when building with -O3

Browse source 
Avoid compiler warnings "‘foo’ may be used uninitialized in this
function" when building with -O3 by checking the return bool value
of format conversion function.

https://bugzilla.gnome.org/show_bug.cgi?id=769116
This commit is contained in:
Josep Torra 2016-07-24 10:00:48 +02:00
parent 61f8ac49cc
commit 9b6b6d1fd5
1 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
ext/sidplay/gstsiddec.cc
View file

@ -21,15 +21,15 @@
/**
* SECTION:element-siddec
*
* This element decodes .sid files to raw audio. .sid files are in fact
* small Commodore 64 programs that are executed on an emulated 6502 CPU and a
* This element decodes .sid files to raw audio. .sid files are in fact
* small Commodore 64 programs that are executed on an emulated 6502 CPU and a
* MOS 6581 sound chip.
*
*
* This plugin will first load the complete program into memory before starting
* the emulator and producing output.
*
*
* Seeking is not (and cannot be) implemented.
*
*
* <refsect2>
* <title>Example pipelines</title>
* |[
@ -394,7 +394,7 @@ play_loop (GstPad * pad)
GstSidDec *siddec;
GstBuffer *out;
GstMapInfo outmap;
gint64 value, offset, time;
gint64 value, offset, time = 0;
GstFormat format;
siddec = GST_SIDDEC (gst_pad_get_parent (pad));
@ -408,29 +408,29 @@ play_loop (GstPad * pad)
/* get offset in samples */
format = GST_FORMAT_DEFAULT;
gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &offset);
GST_BUFFER_OFFSET (out) = offset;
if (gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &offset))
GST_BUFFER_OFFSET (out) = offset;
/* get current timestamp */
format = GST_FORMAT_TIME;
gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &time);
GST_BUFFER_TIMESTAMP (out) = time;
if (gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &time))
GST_BUFFER_TIMESTAMP (out) = time;
/* update position and get new timestamp to calculate duration */
siddec->total_bytes += siddec->blocksize;
/* get offset in samples */
format = GST_FORMAT_DEFAULT;
gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &value);
GST_BUFFER_OFFSET_END (out) = value;
if (gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &value))
GST_BUFFER_OFFSET_END (out) = value;
format = GST_FORMAT_TIME;
gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &value);
GST_BUFFER_DURATION (out) = value - time;
if (gst_siddec_src_convert (siddec->srcpad,
GST_FORMAT_BYTES, siddec->total_bytes, &format, &value))
GST_BUFFER_DURATION (out) = value - time;
if ((ret = gst_pad_push (siddec->srcpad, out)) != GST_FLOW_OK)
goto pause;