mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-05 09:00:54 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests: gstelement: Fix test_add_pad_while_paused flakiness

Browse source 
`gst_element_remove_pad()` doesn't automatically deactivate the pad, it has to
be done explicitly beforehand, otherwise the pad task might be left dangling,
exposed to undefined behaviour.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3651>
This commit is contained in:
Philippe Normand 2022-12-28 17:42:31 +00:00 committed by Tim-Philipp Müller
parent ebe44034c1
commit 9aa8393e06
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
subprojects/gstreamer/tests/check/gst/gstelement.c
View file

@ -113,6 +113,7 @@ GST_START_TEST (test_add_pad_while_paused)
gst_element_set_state (e, GST_STATE_PAUSED);
{
GstPad *old_pad = gst_element_get_static_pad (e, "src");
gst_pad_set_active (old_pad, FALSE);
gst_element_remove_pad (e, old_pad);
gst_object_unref (old_pad);
}