setup.py: Use the detected Ninja and quote build_dir

The build_dir is an absolute path, so quote it.

We don't really need to use the absolute path to Ninja in git-update
since we pass it to subprocess.call which will do an shutil.which
This commit is contained in:
Nirbheek Chauhan 2017-01-03 02:06:42 +05:30
parent 9c15b9a136
commit 9a64b727bf
2 changed files with 3 additions and 4 deletions

View file

@ -45,10 +45,9 @@ def git(*args, repository_path='.'):
stderr=subprocess.STDOUT).decode() stderr=subprocess.STDOUT).decode()
def accept_command(commands): def accept_command(commands):
"""Search @commands and returns the first found absolute path.""" """Search @commands and returns the first found command"""
for command in commands: for command in commands:
command = shutil.which(command) if shutil.which(command):
if command:
return command return command
return None return None

View file

@ -54,7 +54,7 @@ class GstBuildConfigurer:
subprocess.check_call( subprocess.check_call(
[sys.executable, meson, "../"] + self.args + self.get_configs(), cwd=build_dir) [sys.executable, meson, "../"] + self.args + self.get_configs(), cwd=build_dir)
print("\nYou can now build GStreamer and its various subprojects running:\n" print("\nYou can now build GStreamer and its various subprojects running:\n"
" $ ninja -C %s" % build_dir) " $ {} -C {!r}".format(ninja, build_dir))
except subprocess.CalledProcessError: except subprocess.CalledProcessError:
return False return False