mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 03:35:21 +00:00
Code Issues 1 Projects Releases Wiki Activity

extractable: check extractable-type of set asset

Browse source 
When setting the asset of a GESExtractable object, first make sure that
the asset's extractable-type matches the type of the object.
This commit is contained in:
Henry Wilkes 2020-02-18 12:14:25 +00:00 committed by Thibault Saunier
parent 1332ed674a
commit 9a459d0cb5
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ges/ges-extractable.c
View file

@ -140,6 +140,7 @@ gboolean
ges_extractable_set_asset (GESExtractable * self, GESAsset * asset) ges_extractable_set_asset (GESExtractable * self, GESAsset * asset)
{ {
GESExtractableInterface *iface; GESExtractableInterface *iface;
GType extract_type;
g_return_val_if_fail (GES_IS_EXTRACTABLE (self), FALSE); g_return_val_if_fail (GES_IS_EXTRACTABLE (self), FALSE);
@ -153,8 +154,15 @@ ges_extractable_set_asset (GESExtractable * self, GESAsset * asset)
return FALSE; return FALSE;
} }
/* FIXME: shouldn't we check that the extractable-type of the asset
* matches our type? */ extract_type = ges_asset_get_extractable_type (asset);
if (G_OBJECT_TYPE (self) != extract_type) {
GST_WARNING_OBJECT (self, "Can not set the asset to %" GST_PTR_FORMAT
" because its extractable-type is %s, rather than %s",
asset, g_type_name (extract_type), G_OBJECT_TYPE_NAME (self));
return FALSE;
}
g_object_set_qdata_full (G_OBJECT (self), ges_asset_key, g_object_set_qdata_full (G_OBJECT (self), ges_asset_key,
gst_object_ref (asset), gst_object_unref); gst_object_ref (asset), gst_object_unref);