mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 11:45:25 +00:00
Code Issues 1 Projects Releases Wiki Activity

autoconvert: Don't hold the object lock when pushing

Browse source 
When pushing out cached events, don't hold the object lock. Avoids
deadlocks starting up DVD playback.
This commit is contained in:
Jan Schmidt 2009-10-21 23:06:56 +01:00
parent 9cc424117c
commit 997f180b85
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
gst/autoconvert/gstautoconvert.c
View file

@ -931,20 +931,23 @@ gst_auto_convert_sink_chain (GstPad * pad, GstBuffer * buffer)
internal_srcpad = gst_auto_convert_get_internal_srcpad (autoconvert);
if (internal_srcpad) {
GList *events = NULL;
GList *l;
GST_OBJECT_LOCK (autoconvert);
if (autoconvert->cached_events) {
GList *l;
GST_DEBUG_OBJECT (autoconvert, "Sending cached events downstream");
autoconvert->cached_events = g_list_reverse (autoconvert->cached_events);
for (l = autoconvert->cached_events; l; l = l->next)
gst_pad_push_event (internal_srcpad, l->data);
g_list_free (autoconvert->cached_events);
events = g_list_reverse (autoconvert->cached_events);
autoconvert->cached_events = NULL;
}
GST_OBJECT_UNLOCK (autoconvert);
if (events) {
GST_DEBUG_OBJECT (autoconvert, "Sending cached events downstream");
for (l = events; l; l = l->next)
gst_pad_push_event (internal_srcpad, l->data);
g_list_free (events);
}
ret = gst_pad_push (internal_srcpad, buffer);
gst_object_unref (internal_srcpad);
} else {