mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-06 14:32:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

playbin: avoid possible deference of null pointer

Browse source 
For safety, check the pointer playbin->curr_group is valid before
reading parameters of the structure.

CID #1291624
This commit is contained in:
Luis de Bethencourt 2015-03-30 10:50:45 +01:00
parent d1f91723be
commit 985ed4847f
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gst/playback/gstplaybin2.c
View file

@ -5734,11 +5734,13 @@ failure:
GstSourceGroup *curr_group; GstSourceGroup *curr_group;
curr_group = playbin->curr_group; curr_group = playbin->curr_group;
if (curr_group && curr_group->active && curr_group->valid) { if (curr_group) {
if (curr_group->active && curr_group->valid) {
/* unlink our pads with the sink */ /* unlink our pads with the sink */
deactivate_group (playbin, curr_group); deactivate_group (playbin, curr_group);
} }
curr_group->valid = FALSE; curr_group->valid = FALSE;
}
/* Swap current and next group back */ /* Swap current and next group back */
playbin->curr_group = playbin->next_group; playbin->curr_group = playbin->next_group;