mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-03-27 11:32:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

splitmuxsrc: Don't return FALSE from event handling.

Browse source 
Returning FALSE because we drop an event means that
internal sources like qtdemux might throw an error
and break the whole pipeline. The only time it can
happen is either flushing or shutdown, and those
will be handled anyway.
This commit is contained in:
Jan Schmidt 2017-11-18 02:01:58 +11:00
parent 7c8aeff262
commit 97e8fd8272
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
gst/multifile/gstsplitmuxpartreader.c
View file

@ -456,12 +456,8 @@ splitmux_part_pad_event (GstPad * pad, GstObject * parent, GstEvent * event)
GST_EVENT_TYPE (event) == GST_EVENT_FLUSH_STOP)
goto drop_event;
if (!block_until_can_push (reader)) {
SPLITMUX_PART_UNLOCK (reader);
gst_object_unref (target);
gst_event_unref (event);
return FALSE;
}
if (!block_until_can_push (reader))
goto drop_event;
switch (GST_EVENT_TYPE (event)) {
case GST_EVENT_GAP:{
@ -1360,6 +1356,8 @@ bus_handler (GstBin * bin, GstMessage * message)
/* Make sure to set the state to failed and wake up the listener
* on error */
SPLITMUX_PART_LOCK (reader);
GST_ERROR_OBJECT (reader, "Got error message from child %" GST_PTR_FORMAT
" marking this reader as failed", GST_MESSAGE_SRC (message));
reader->prep_state = PART_STATE_FAILED;
SPLITMUX_PART_BROADCAST (reader);
SPLITMUX_PART_UNLOCK (reader);