mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

plugins: check gst_buffer_pool_set_config()

Browse source 
Check the return value of gst_buffer_pool_set_config(). If it fails an error
message is posted in the bus.
This commit is contained in:
Víctor Manuel Jáquez Leal 2015-04-29 12:27:43 +02:00
parent 100d5971b5
commit 97b768675a
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
gst/vaapi/gstvaapipluginbase.c
View file

@ -700,7 +700,8 @@ gst_vaapi_plugin_base_decide_allocation (GstVaapiPluginBase * plugin,
gst_buffer_pool_config_set_params (config, caps, size, min, max); gst_buffer_pool_config_set_params (config, caps, size, min, max);
gst_buffer_pool_config_add_option (config, gst_buffer_pool_config_add_option (config,
GST_BUFFER_POOL_OPTION_VAAPI_VIDEO_META); GST_BUFFER_POOL_OPTION_VAAPI_VIDEO_META);
gst_buffer_pool_set_config (pool, config); if (!gst_buffer_pool_set_config (pool, config))
goto config_failed;
} }
/* Check whether GstVideoMeta, or GstVideoAlignment, is needed (raw video) */ /* Check whether GstVideoMeta, or GstVideoAlignment, is needed (raw video) */
@ -708,12 +709,14 @@ gst_vaapi_plugin_base_decide_allocation (GstVaapiPluginBase * plugin,
config = gst_buffer_pool_get_config (pool); config = gst_buffer_pool_get_config (pool);
gst_buffer_pool_config_add_option (config, gst_buffer_pool_config_add_option (config,
GST_BUFFER_POOL_OPTION_VIDEO_META); GST_BUFFER_POOL_OPTION_VIDEO_META);
gst_buffer_pool_set_config (pool, config); if (!gst_buffer_pool_set_config (pool, config))
goto config_failed;
} else if (has_video_alignment) { } else if (has_video_alignment) {
config = gst_buffer_pool_get_config (pool); config = gst_buffer_pool_get_config (pool);
gst_buffer_pool_config_add_option (config, gst_buffer_pool_config_add_option (config,
GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT); GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT);
gst_buffer_pool_set_config (pool, config); if (!gst_buffer_pool_set_config (pool, config))
goto config_failed;
} }
/* GstVideoGLTextureUploadMeta (OpenGL) */ /* GstVideoGLTextureUploadMeta (OpenGL) */
@ -722,7 +725,8 @@ gst_vaapi_plugin_base_decide_allocation (GstVaapiPluginBase * plugin,
config = gst_buffer_pool_get_config (pool); config = gst_buffer_pool_get_config (pool);
gst_buffer_pool_config_add_option (config, gst_buffer_pool_config_add_option (config,
GST_BUFFER_POOL_OPTION_VIDEO_GL_TEXTURE_UPLOAD_META); GST_BUFFER_POOL_OPTION_VIDEO_GL_TEXTURE_UPLOAD_META);
gst_buffer_pool_set_config (pool, config); if (!gst_buffer_pool_set_config (pool, config))
goto config_failed;
} }
#endif #endif
@ -752,6 +756,15 @@ error_create_pool:
GST_ERROR_OBJECT (plugin, "failed to create buffer pool"); GST_ERROR_OBJECT (plugin, "failed to create buffer pool");
return FALSE; return FALSE;
} }
config_failed:
{
if (pool)
gst_object_unref (pool);
GST_ELEMENT_ERROR (plugin, RESOURCE, SETTINGS,
("Failed to configure the buffer pool"),
("Configuration is most likely invalid, please report this issue."));
return FALSE;
}
} }
/** /**