mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-28 03:00:35 +00:00
Code Issues 1 Projects Releases Wiki Activity

tests/webrtc: fix racy test with a prenegotiated data channel

Browse source 
If both data channels become ready simultaneously, then the two integer
read-add-update cycles can execute concurrently and only ever increment
once instead of the required twice.  Use an atomic add instead.
This commit is contained in:
Matthew Waters 2019-03-08 00:37:39 +11:00
parent be011d2086
commit 979daea7f2
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ext/webrtc/webrtcdatachannel.h
View file

@ -75,8 +75,9 @@ struct _GstWebRTCDataChannelClass
};
void gst_webrtc_data_channel_start_negotiation (GstWebRTCDataChannel *channel);
void gst_webrtc_data_channel_set_sctp_transport (GstWebRTCDataChannel *channel,
GstWebRTCSCTPTransport *sctp);
G_GNUC_INTERNAL
void gst_webrtc_data_channel_link_to_sctp (GstWebRTCDataChannel *channel,
GstWebRTCSCTPTransport *sctp_transport);
G_END_DECLS

3
tests/check/elements/webrtcbin.c
View file

@ -1899,8 +1899,9 @@ _on_ready_state_notify (GObject * channel, GParamSpec * pspec,
g_object_get (channel, "ready-state", &ready_state, NULL);
if (ready_state == GST_WEBRTC_DATA_CHANNEL_STATE_OPEN) {
if (++(*n_ready) >= 2)
if (g_atomic_int_add (n_ready, 1) >= 1) {
test_webrtc_signal_state (t, STATE_CUSTOM);
}
}
}