mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-30 19:18:31 +00:00
Code Issues 1 Projects Releases Wiki Activity

pango: fix bad unref and crashes with multiple text overlays

Browse source 
gst_element_class_get_pad_template() does not return a ref,
so we mustn't unref the template returned. Fixes crashes
when switching back and forth between different types of
subtitle streams.
This commit is contained in:
Tim-Philipp Müller 2012-08-21 22:51:38 +01:00
parent bec14e2b05
commit 96faac2891
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ext/pango/gstbasetextoverlay.c
View file

@ -629,7 +629,6 @@ gst_base_text_overlay_init (GstBaseTextOverlay * overlay,
if (template) { if (template) {
/* text sink */ /* text sink */
overlay->text_sinkpad = gst_pad_new_from_template (template, "text_sink"); overlay->text_sinkpad = gst_pad_new_from_template (template, "text_sink");
gst_object_unref (template);
gst_pad_set_event_function (overlay->text_sinkpad, gst_pad_set_event_function (overlay->text_sinkpad,
GST_DEBUG_FUNCPTR (gst_base_text_overlay_text_event)); GST_DEBUG_FUNCPTR (gst_base_text_overlay_text_event));