mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 06:54:49 +00:00
Code Issues 1 Projects Releases Wiki Activity

controller: logging tweaks

Browse source 
Don't log in _new before we have the log category. Use _OBJECT variants.
This commit is contained in:
Stefan Sauer 2011-11-04 21:35:55 +01:00
parent be70cebc31
commit 95c6fde6ac
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gst/gstcontroller.c
View file

@ -222,12 +222,14 @@ gst_controller_add_property (GstController * self, const gchar * name)
GstControlledProperty *prop; GstControlledProperty *prop;
/* create GstControlledProperty and add to self->properties list */ /* create GstControlledProperty and add to self->properties list */
if ((prop = gst_controlled_property_new (self->object, name))) if ((prop = gst_controlled_property_new (self->object, name))) {
self->properties = g_list_prepend (self->properties, prop); self->properties = g_list_prepend (self->properties, prop);
else GST_DEBUG_OBJECT (self->object, "property %s added", name);
} else
res = FALSE; res = FALSE;
} else { } else {
GST_WARNING ("trying to control property %s again", name); GST_WARNING_OBJECT (self->object, "trying to control property %s again",
name);
} }
return res; return res;
} }
@ -251,6 +253,7 @@ gst_controller_remove_property (GstController * self, const gchar * name)
self->properties = g_list_remove (self->properties, prop); self->properties = g_list_remove (self->properties, prop);
//g_signal_handler_disconnect (self->object, prop->notify_handler_id); //g_signal_handler_disconnect (self->object, prop->notify_handler_id);
gst_controlled_property_free (prop); gst_controlled_property_free (prop);
GST_DEBUG_OBJECT (self->object, "property %s removed", name);
} else { } else {
res = FALSE; res = FALSE;
} }
@ -276,8 +279,6 @@ gst_controller_new_valist (GstObject * object, va_list var_args)
g_return_val_if_fail (G_IS_OBJECT (object), NULL); g_return_val_if_fail (G_IS_OBJECT (object), NULL);
GST_INFO ("setting up a new controller");
self = g_object_newv (GST_TYPE_CONTROLLER, 0, NULL); self = g_object_newv (GST_TYPE_CONTROLLER, 0, NULL);
self->object = g_object_ref (object); self->object = g_object_ref (object);
@ -311,8 +312,6 @@ gst_controller_new_list (GstObject * object, GList * list)
g_return_val_if_fail (G_IS_OBJECT (object), NULL); g_return_val_if_fail (G_IS_OBJECT (object), NULL);
GST_INFO ("setting up a new controller");
self = g_object_newv (GST_TYPE_CONTROLLER, 0, NULL); self = g_object_newv (GST_TYPE_CONTROLLER, 0, NULL);
self->object = g_object_ref (object); self->object = g_object_ref (object);