mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-07-10 00:25:53 +00:00
Code Issues 1 Projects Releases Wiki Activity

uridecodebin: double-check property type before blindly setting/proxying values

Browse source
This commit is contained in:
Tim-Philipp Müller 2011-11-24 01:30:50 +00:00
parent 16f6d13980
commit 95138db216
1 changed files with 22 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
gst/playback/gsturidecodebin.c
View file

@ -1198,7 +1198,9 @@ static const gchar *download_media[] = {
static GstElement * static GstElement *
gen_source_element (GstURIDecodeBin * decoder) gen_source_element (GstURIDecodeBin * decoder)
{ {
GObjectClass *source_class;
GstElement *source; GstElement *source;
GParamSpec *pspec;
if (!decoder->uri) if (!decoder->uri)
goto no_uri; goto no_uri;
@ -1223,25 +1225,34 @@ gen_source_element (GstURIDecodeBin * decoder)
decoder->need_queue = IS_QUEUE_URI (decoder->uri); decoder->need_queue = IS_QUEUE_URI (decoder->uri);
GST_LOG_OBJECT (decoder, "source needs queue: %d", decoder->need_queue); GST_LOG_OBJECT (decoder, "source needs queue: %d", decoder->need_queue);
source_class = G_OBJECT_GET_CLASS (source);
/* make HTTP sources send extra headers so we get icecast /* make HTTP sources send extra headers so we get icecast
* metadata in case the stream is an icecast stream */ * metadata in case the stream is an icecast stream */
if (!strncmp (decoder->uri, "http://", 7) && if (!strncmp (decoder->uri, "http://", 7) &&
g_object_class_find_property (G_OBJECT_GET_CLASS (source), g_object_class_find_property (source_class, "iradio-mode")) {
"iradio-mode")) {
GST_LOG_OBJECT (decoder, "configuring iradio-mode"); GST_LOG_OBJECT (decoder, "configuring iradio-mode");
g_object_set (source, "iradio-mode", TRUE, NULL); g_object_set (source, "iradio-mode", TRUE, NULL);
} }
if (g_object_class_find_property (G_OBJECT_GET_CLASS (source), pspec = g_object_class_find_property (source_class, "connection-speed");
"connection-speed")) { if (pspec != NULL) {
GST_DEBUG_OBJECT (decoder, if (G_PARAM_SPEC_VALUE_TYPE (pspec) == G_TYPE_UINT64 ||
"setting connection-speed=%d to source element", G_PARAM_SPEC_VALUE_TYPE (pspec) == G_TYPE_INT64) {
decoder->connection_speed / 1000); GST_DEBUG_OBJECT (decoder,
g_object_set (source, "connection-speed", "setting connection-speed=%" G_GUINT64_FORMAT " on source element %s",
decoder->connection_speed / 1000, NULL); decoder->connection_speed / 1000, G_OBJECT_TYPE_NAME (source));
g_object_set (source, "connection-speed",
decoder->connection_speed / 1000, NULL);
} else {
g_warning ("connection-speed property of '%s' is not a 64-bit int type",
G_OBJECT_TYPE_NAME (source));
}
} }
if (g_object_class_find_property (G_OBJECT_GET_CLASS (source),
"subtitle-encoding")) { pspec = g_object_class_find_property (source_class, "subtitle-encoding");
if (pspec != NULL && G_PARAM_SPEC_VALUE_TYPE (pspec) == G_TYPE_STRING) {
GST_DEBUG_OBJECT (decoder, GST_DEBUG_OBJECT (decoder,
"setting subtitle-encoding=%s to source element", decoder->encoding); "setting subtitle-encoding=%s to source element", decoder->encoding);
g_object_set (source, "subtitle-encoding", decoder->encoding, NULL); g_object_set (source, "subtitle-encoding", decoder->encoding, NULL);