mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-02 20:42:30 +00:00
Code Issues 1 Projects Releases Wiki Activity

equalizer: Use floating point arithmetic internally for the int16 mode

Browse source 
By using int32 arithmetic we will introduce distortions as the
IIR filter is very sensitive to rounding errors. Fixes bug #580214.
This commit is contained in:
Ghislain 'Aus' Lacroix 2009-05-28 12:39:46 +02:00 committed by Sebastian Dröge
parent 0c61b20ac6
commit 9507cdc84c
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
gst/equalizer/gstiirequalizer.c
View file

@ -392,9 +392,9 @@ setup_filter (GstIirEqualizer * equ, GstIirEqualizerBand * band)
gain = arg_to_scale (band->gain); gain = arg_to_scale (band->gain);
if (band->freq / GST_AUDIO_FILTER (equ)->format.rate > 0.5) if (band->freq / GST_AUDIO_FILTER (equ)->format.rate >= 0.5)
omega = M_PI; omega = M_PI;
else if (band->freq < 0.0) else if (band->freq <= 0.0)
omega = 0.0; omega = 0.0;
else else
omega = 2.0 * M_PI * (band->freq / GST_AUDIO_FILTER (equ)->format.rate); omega = 2.0 * M_PI * (band->freq / GST_AUDIO_FILTER (equ)->format.rate);
@ -557,9 +557,9 @@ one_step_ ## TYPE (GstIirEqualizerBand *filter, \
SecondOrderHistory ## TYPE *history, BIG_TYPE input) \ SecondOrderHistory ## TYPE *history, BIG_TYPE input) \
{ \ { \
/* calculate output */ \ /* calculate output */ \
BIG_TYPE output = floor (filter->a0 * input + \ BIG_TYPE output = filter->a0 * input + \
filter->a1 * history->x1 + filter->a2 * history->x2 + \ filter->a1 * history->x1 + filter->a2 * history->x2 + \
filter->b1 * history->y1 + filter->b2 * history->y2 + 0.5); \ filter->b1 * history->y1 + filter->b2 * history->y2; \
/* update history */ \ /* update history */ \
history->y2 = history->y1; \ history->y2 = history->y1; \
history->y1 = output; \ history->y1 = output; \
@ -591,7 +591,7 @@ guint size, guint channels) \
history++; \ history++; \
} \ } \
cur = CLAMP (cur, MIN_VAL, MAX_VAL); \ cur = CLAMP (cur, MIN_VAL, MAX_VAL); \
*((TYPE *) data) = (TYPE) cur; \ *((TYPE *) data) = (TYPE) floor (cur); \
data += sizeof (TYPE); \ data += sizeof (TYPE); \
} \ } \
} \ } \
@ -647,7 +647,7 @@ guint size, guint channels) \
} \ } \
} }
CREATE_OPTIMIZED_FUNCTIONS_INT (gint16, gint32, -32768, 32767); CREATE_OPTIMIZED_FUNCTIONS_INT (gint16, gfloat, -32768.0, 32767.0);
CREATE_OPTIMIZED_FUNCTIONS (gfloat); CREATE_OPTIMIZED_FUNCTIONS (gfloat);
CREATE_OPTIMIZED_FUNCTIONS (gdouble); CREATE_OPTIMIZED_FUNCTIONS (gdouble);