mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-02-17 03:35:21 +00:00
Code Issues 1 Projects Releases Wiki Activity

Revert "rtsp-session-pool: Make sure session IDs are properly URI-escaped"

Browse source 
This reverts commit 935e8f852d.

RFC 2326 states that session IDs may consist of alphanumeric as well as
the safe characters $-_.+ -- N.B. the percent character is not allowed.

Previously the session ID was URI-escaped, this meant that any character
which was not alphanumeric or any of the characters +-._~ would be
percent encoded. While the RFC (surprisingly) mentions that linear white
space in session IDs should be URI-escaped, it does not say anything
about other characters. Moreover no white space is allowed in the
session ID. Finally the percent character which is the result of
URI-escaping is not allowed in a session ID.

So there is no reason to do any URI-escaping, and now it is removed.

https://bugzilla.gnome.org/show_bug.cgi?id=742869
This commit is contained in:
Sebastian Rasmussen 2015-01-13 15:29:29 +01:00 committed by Sebastian Dröge
parent d535cd8cbb
commit 94f3e18c5b
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gst/rtsp-server/rtsp-session-pool.c
View file

@ -317,7 +317,7 @@ gst_rtsp_session_pool_find (GstRTSPSessionPool * pool, const gchar * sessionid)
static gchar *
create_session_id (GstRTSPSessionPool * pool)
{
gchar id[17];
gchar id[16];
gint i;
for (i = 0; i < 16; i++) {
@ -325,9 +325,8 @@ create_session_id (GstRTSPSessionPool * pool)
session_id_charset[g_random_int_range (0,
G_N_ELEMENTS (session_id_charset))];
}
id[16] = 0;
return g_uri_escape_string (id, NULL, FALSE);
return g_strndup (id, 16);
}
static GstRTSPSession *