mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-10-04 17:52:29 +00:00
Code Issues 1 Projects Releases Wiki Activity

playbin2: Don't hold the playbin lock in the autoplug-continue callback

Browse source 
It's not necessary there as the group lock already protects everything
we access here and causes deadlocks in some cases.

Fixes bug #673708.
This commit is contained in:
Akihiro Tsukada 2012-04-17 09:54:09 +02:00 committed by Sebastian Dröge
parent 8f2a048e5f
commit 94beeb713a
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gst/playback/gstplaybin2.c
View file

@ -3176,7 +3176,6 @@ autoplug_continue_cb (GstElement * element, GstPad * pad, GstCaps * caps,
GstElement *sink; GstElement *sink;
GstPad *sinkpad = NULL; GstPad *sinkpad = NULL;
GST_PLAY_BIN_LOCK (group->playbin);
GST_SOURCE_GROUP_LOCK (group); GST_SOURCE_GROUP_LOCK (group);
if ((sink = group->playbin->text_sink)) if ((sink = group->playbin->text_sink))
@ -3253,7 +3252,6 @@ autoplug_continue_cb (GstElement * element, GstPad * pad, GstCaps * caps,
done: done:
GST_SOURCE_GROUP_UNLOCK (group); GST_SOURCE_GROUP_UNLOCK (group);
GST_PLAY_BIN_UNLOCK (group->playbin);
GST_DEBUG_OBJECT (group->playbin, GST_DEBUG_OBJECT (group->playbin,
"continue autoplugging group %p for %s:%s, %" GST_PTR_FORMAT ": %d", "continue autoplugging group %p for %s:%s, %" GST_PTR_FORMAT ": %d",