mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 16:08:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

playsink: avoid crashing on the way out when needed chain missing

Browse source
This commit is contained in:
Mark Nauwelaerts 2011-02-23 10:32:08 +01:00
parent eae16a78b9
commit 948e4d50a6
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gst/playback/gstplaysink.c
View file

@ -2217,6 +2217,8 @@ gst_play_sink_reconfigure (GstPlaySink * playsink)
if (!playsink->videochain) if (!playsink->videochain)
playsink->videochain = gen_video_chain (playsink, raw, async); playsink->videochain = gen_video_chain (playsink, raw, async);
if (!playsink->videochain)
goto no_chain;
if (!playsink->video_sinkpad_stream_synchronizer) { if (!playsink->video_sinkpad_stream_synchronizer) {
GstIterator *it; GstIterator *it;
@ -2241,6 +2243,8 @@ gst_play_sink_reconfigure (GstPlaySink * playsink)
if (!playsink->videodeinterlacechain) if (!playsink->videodeinterlacechain)
playsink->videodeinterlacechain = playsink->videodeinterlacechain =
gen_video_deinterlace_chain (playsink); gen_video_deinterlace_chain (playsink);
if (!playsink->videodeinterlacechain)
goto no_chain;
GST_DEBUG_OBJECT (playsink, "adding video deinterlace chain"); GST_DEBUG_OBJECT (playsink, "adding video deinterlace chain");
@ -2574,6 +2578,15 @@ gst_play_sink_reconfigure (GstPlaySink * playsink)
GST_PLAY_SINK_UNLOCK (playsink); GST_PLAY_SINK_UNLOCK (playsink);
return TRUE; return TRUE;
/* ERRORS */
no_chain:
{
/* gen_ chain already posted error */
GST_DEBUG_OBJECT (playsink, "failed to setup chain");
GST_PLAY_SINK_UNLOCK (playsink);
return FALSE;
}
} }
/** /**