mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-06-07 07:58:51 +00:00
Code Issues 1 Projects Releases Wiki Activity

videoframe: Initialise GstVideoFrame to zeroes if mapping fails

Browse source 
This should allow for more meaningful errors. Dereferencing NULL
is more useful information than dereferencing a random address
happened to be on the stack.
This commit is contained in:
Sebastian Dröge 2014-04-16 19:53:14 +02:00
parent 22e12979ee
commit 9398207101
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
gst-libs/gst/video/video-frame.c
View file

@ -130,6 +130,7 @@ gst_video_frame_map_id (GstVideoFrame * frame, GstVideoInfo * info,
no_metadata: no_metadata:
{ {
GST_ERROR ("no GstVideoMeta for id %d", id); GST_ERROR ("no GstVideoMeta for id %d", id);
memset (frame, 0, sizeof (GstVideoFrame));
return FALSE; return FALSE;
} }
frame_map_failed: frame_map_failed:
@ -137,6 +138,7 @@ frame_map_failed:
GST_ERROR ("failed to map video frame plane %d", i); GST_ERROR ("failed to map video frame plane %d", i);
while (--i >= 0) while (--i >= 0)
gst_video_meta_unmap (meta, i, &frame->map[i]); gst_video_meta_unmap (meta, i, &frame->map[i]);
memset (frame, 0, sizeof (GstVideoFrame));
return FALSE; return FALSE;
} }
map_failed: map_failed:
@ -149,6 +151,7 @@ invalid_size:
GST_ERROR ("invalid buffer size %" G_GSIZE_FORMAT " < %" G_GSIZE_FORMAT, GST_ERROR ("invalid buffer size %" G_GSIZE_FORMAT " < %" G_GSIZE_FORMAT,
frame->map[0].size, info->size); frame->map[0].size, info->size);
gst_buffer_unmap (buffer, &frame->map[0]); gst_buffer_unmap (buffer, &frame->map[0]);
memset (frame, 0, sizeof (GstVideoFrame));
return FALSE; return FALSE;
} }
} }