mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 09:10:36 +00:00
Code Issues 1 Projects Releases Wiki Activity

playbin: fix suburidecodebin leak

Browse source 
We take a ref before removing which was never freeded.
The element is still alive anyway because the group has its own ref as
well.

Fix a leak with the 'test_suburi_error_wrongproto' test.

https://bugzilla.gnome.org/show_bug.cgi?id=766515
This commit is contained in:
Guillaume Desmottes 2016-05-16 15:39:02 +02:00 committed by Sebastian Dröge
parent ece702920f
commit 92343b6f20
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
gst/playback/gstplaybin2.c
View file

@ -3017,6 +3017,7 @@ gst_play_bin_handle_message (GstBin * bin, GstMessage * msg)
gst_object_ref (group->suburidecodebin); gst_object_ref (group->suburidecodebin);
gst_bin_remove (bin, group->suburidecodebin); gst_bin_remove (bin, group->suburidecodebin);
gst_element_set_locked_state (group->suburidecodebin, FALSE); gst_element_set_locked_state (group->suburidecodebin, FALSE);
gst_object_unref (group->suburidecodebin);
GST_SOURCE_GROUP_LOCK (group); GST_SOURCE_GROUP_LOCK (group);
g_free (group->suburi); g_free (group->suburi);