gst/id3demux/gstid3demux.c: Don't put function calls in g_return_if_fail() statements, or they'll be replaced with NO...

Original commit message from CVS:
* gst/id3demux/gstid3demux.c: (gst_id3demux_remove_srcpad):
Don't put function calls in g_return_if_fail() statements,
or they'll be replaced with NOOPs if someone compiles with
G_DISABLE_CHECKS defined.
This commit is contained in:
Tim-Philipp Müller 2006-01-25 22:05:28 +00:00
parent 6021f2b54f
commit 916d083e99
2 changed files with 12 additions and 3 deletions

View file

@ -1,3 +1,10 @@
2006-01-25 Tim-Philipp Müller <tim at centricular dot net>
* gst/id3demux/gstid3demux.c: (gst_id3demux_remove_srcpad):
Don't put function calls in g_return_if_fail() statements,
or they'll be replaced with NOOPs if someone compiles with
G_DISABLE_CHECKS defined.
2006-01-25 Jan Schmidt <thaytan@mad.scientist.com>
* gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame):

View file

@ -291,15 +291,17 @@ gst_id3demux_add_srcpad (GstID3Demux * id3demux, GstCaps * new_caps)
static gboolean
gst_id3demux_remove_srcpad (GstID3Demux * id3demux)
{
gboolean res = TRUE;
if (id3demux->srcpad != NULL) {
GST_DEBUG_OBJECT (id3demux, "Removing src pad");
g_return_val_if_fail (gst_element_remove_pad (GST_ELEMENT (id3demux),
id3demux->srcpad), FALSE);
res = gst_element_remove_pad (GST_ELEMENT (id3demux), id3demux->srcpad);
g_return_val_if_fail (res != FALSE, FALSE);
gst_object_unref (id3demux->srcpad);
id3demux->srcpad = NULL;
}
return TRUE;
return res;
};
static gboolean