mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-04-26 05:16:13 +00:00
Code Issues 1 Projects Releases Wiki Activity

xingmux: Fix unaligned memory access

Browse source 
ARM/SPARC need 32bit alignment but xingmux accesses possibly
unaligned memory, which leads to SIGBUS.

Fixes bug #586464.
This commit is contained in:
Arnaud Patard 2010-01-11 12:23:35 +01:00 committed by Sebastian Dröge
parent 84d80fffcd
commit 9094dc1bc6
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gst/mpegaudioparse/gstxingmux.c
View file

@ -239,7 +239,7 @@ has_xing_header (guint32 header, guchar * data, gsize size)
static GstBuffer * static GstBuffer *
generate_xing_header (GstXingMux * xing) generate_xing_header (GstXingMux * xing)
{ {
guint32 *xing_flags; guint8 *xing_flags;
guint32 xing_flags_tmp = 0; guint32 xing_flags_tmp = 0;
GstBuffer *xing_header; GstBuffer *xing_header;
guchar *data; guchar *data;
@ -288,7 +288,7 @@ generate_xing_header (GstXingMux * xing)
memcpy (data, "Xing", 4); memcpy (data, "Xing", 4);
data += 4; data += 4;
xing_flags = (guint32 *) data; xing_flags = data;
data += 4; data += 4;
if (xing->duration != GST_CLOCK_TIME_NONE) { if (xing->duration != GST_CLOCK_TIME_NONE) {
@ -379,7 +379,7 @@ generate_xing_header (GstXingMux * xing)
} }
} }
GST_DEBUG ("Setting Xing flags to 0x%x\n", *xing_flags); GST_DEBUG ("Setting Xing flags to 0x%x\n", xing_flags_tmp);
xing_flags_tmp = GUINT32_TO_BE (xing_flags_tmp); xing_flags_tmp = GUINT32_TO_BE (xing_flags_tmp);
memcpy (xing_flags, &xing_flags_tmp, 4); memcpy (xing_flags, &xing_flags_tmp, 4);
return xing_header; return xing_header;